Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose config database endpoint #981

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Expose config database endpoint #981

merged 1 commit into from
Sep 20, 2023

Conversation

mlabouardy
Copy link
Collaborator

@mlabouardy mlabouardy commented Sep 20, 2023

Problem

Through the new onboarding wizard, users would be able to connect Komiser to an external database (Postgres or SQLite), hence an API endpoint is needed to establish the connection.

Solution

Exposed a new endpoint to allow users to connect an external database.

How to Test

The following endpoint can be used to integrate a database:
POST /databases
It expects the following payload:

{
    "type": "SQLITE",
    "file": "komiser.db"
}


{
    "type": "POSTGRES",
    "hostname": "localhost:5432",
    "username": "komiser",
    "password": "komiser",
    "database": "demo"
}

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]

@mlabouardy mlabouardy marked this pull request as ready for review September 20, 2023 10:06
@mlabouardy mlabouardy merged commit 6c3c23c into develop Sep 20, 2023
3 checks passed
@mlabouardy mlabouardy deleted the feature/tech-1657 branch September 20, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant