Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow user to configure a database #985

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

greghub
Copy link
Contributor

@greghub greghub commented Sep 21, 2023

Problem

Today users have no possibility to add a database

Solution

[Provide a detailed explanation of the solution you are proposing, including any relevant code snippets or screenshots.]

Changes Made

  • [List the changes you made in this pull request, including any new features or bug fixes.]

How to Test

[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]

Screenshots

Screenshot 2023-09-26 at 18 12 25 Screenshot 2023-09-26 at 18 12 52 Screenshot 2023-09-26 at 18 17 24

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]

@greghub greghub force-pushed the feature/tech-1645 branch 2 times, most recently from 732981a to c22a0b6 Compare September 26, 2023 16:14
@greghub greghub marked this pull request as ready for review September 26, 2023 16:20
Copy link
Contributor

@Kolawole99 Kolawole99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlabouardy mlabouardy added this to the v3.1.1 milestone Sep 27, 2023
@mlabouardy mlabouardy merged commit 791ef40 into develop Sep 27, 2023
2 checks passed
@mlabouardy mlabouardy deleted the feature/tech-1645 branch September 27, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants