-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow user to connect multiple cloud accounts #989
Conversation
0e8d350
to
ad95798
Compare
@mlabouardy please check if the payloads are correct (you can do it in dashboard/utils/cloudAccountHelpers.ts). Also, a few things are missing since I didn't know what to put there:
|
ad95798
to
51e22c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@greghub are you planning to address the above comments?
51e22c8
to
83a4051
Compare
@mlabouardy all issues addressed + more fixes + more refactors. ready to review |
on it :) |
644d537
to
f17667b
Compare
f17667b
to
d9f4118
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
Problem
Users cannot add cloud accounts during onboarding
Solution
Add/complete the flow for adding cloud accounts during onboarding
Changes Made
How to Test
[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]
Screenshots
[Include screenshots, if relevant, to help reviewers understand the changes you made.]
Notes
[Any additional notes or information that you would like to share with the reviewers.]
Checklist
Reviewers
@[username of the reviewer]