Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric Stream cost calculation #990

Merged

Conversation

Azanul
Copy link
Collaborator

@Azanul Azanul commented Sep 23, 2023

Problem

Issue #878

Solution

metric stream cost = update cost * no. of updates

Fetching MetricUpdate cost using pricing API and update count using cloudwatch statistics API.

ref:

Changes Made

Notes

  • Ignored the AWS Kinesis Data Firehose surcharge

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy
@ShubhamPalriwala

Signed-off-by: Azanul <azanulhaque@gmail.com>
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Azanul for the PR. I requested a small change before merging the PR :)

providers/aws/cloudwatch/log_metrics.go Outdated Show resolved Hide resolved
@mlabouardy mlabouardy added the aws label Sep 24, 2023
@mlabouardy mlabouardy added this to the v3.1.1 milestone Sep 24, 2023
Signed-off-by: Azanul <azanulhaque@gmail.com>
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mlabouardy mlabouardy merged commit 42ba5f2 into tailwarden:develop Sep 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cost Calculation for AWS Cloudwatch Log Metrics
2 participants