Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests for products #198

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

PollySt
Copy link
Collaborator

@PollySt PollySt commented Jan 30, 2024

  • created a test for the product color and size selection
  • updated README
  • added constants
  • renamed variables

If you don't want to invoke CI, put [skip ci] in the commit message

Screenshots

Test Plan (Steps to test):

Checklist:

  • Create a Test Plan
  • Changes Communicated (in commits or above)
  • Docs Updated
  • Storybook Updated

@PollySt PollySt self-assigned this Jan 30, 2024
Copy link

This pull request has been linked to Shortcut Story #12509: E2E tests for products [Penny].

Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for penny-ecommerce ready!

Name Link
🔨 Latest commit 6107309
🔍 Latest deploy log https://app.netlify.com/sites/penny-ecommerce/deploys/65ba1d42c9485700084802ee
😎 Deploy Preview https://deploy-preview-198--penny-ecommerce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
penny ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 10:16am

Copy link

github-actions bot commented Jan 30, 2024

Lighthouse Report: desktop

Category Score
Path: / Report
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 100
Path: /products/basic-tee-6-pack Report
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 100
Path: /collections/men Report
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 100

Copy link

github-actions bot commented Jan 30, 2024

Lighthouse Report: mobile

Category Score
Path: / Report
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 100
Path: /products/basic-tee-6-pack Report
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 100
Path: /collections/men Report
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 100

@incompl incompl merged commit 7d930f1 into main Feb 1, 2024
16 checks passed
@incompl incompl deleted the sc-12509/chore/e2e-tests-for-products-penny branch February 1, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants