New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup deprecations to develop next major version (v2) #515

Merged

sjoerdtalsma merged 41 commits into develop from develop-v2

Nov 11, 2024

Contributor

sjoerdtalsma commented Nov 4, 2024 •

edited

Loading

Main tasks to create new development baseline for next major release (v2).

Java version bumped to Java8 mimimum
ContextManager.getActiveContext() replaced by getActiveContextValue().
ContextManager.clear() ~~will require an implementation.~~ is part of ContextManager interface.
All @Deprecated(forRemoval=true) is to be removed.
Document @since 2.0.0 for new functionality

coveralls commented Nov 4, 2024 •

edited

Loading

coverage: 94.949% (+3.3%) from 91.679%
when pulling 74c436a on develop-v2
into 72abd11 on develop.

sjoerdtalsma force-pushed the develop-v2 branch 2 times, most recently from 4771761 to 8eac61d Compare

November 8, 2024 12:30

sjoerdtalsma marked this pull request as ready for review

November 8, 2024 12:36

Contributor Author

sjoerdtalsma commented Nov 8, 2024

@Marcono1234 I hate to ask, but since you contributed before, could you have a look at this pull request I have prepared as new baseline for a greatly simplified, quicker 2.0 version?

By no means you have to do a full, detailed review (although welcome).
A quick opinion on the API changes would already be greatly appreciated! 🙏

sjoerdtalsma added 25 commits

November 11, 2024 22:08


          Start a new branch for next major release

4b79b4b

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Update readme.md

64e9f2a


          Update readme.md

58c2b91


          Remove deprecated Context interface.

8a47c52

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Remove deprecated ContextTimer interface.

679bc3e

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Remove deprecated ContextSnapshot interface.

4d50b09

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Bump minimum java version to 1.8

18ac134

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Replace deprecated ContextSnapshotSupplier with Supplier<ContextSnaps…

e2033ec

…hot>

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Remove deprecated Wrapper class.

541bc35

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Remove deprecated WrapperWithContext class.

d4d2757

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Remove deprecated DelegatingFuture class.

c637edc

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Remove deprecated DelegatingExecutorService class.

1ac5e5f

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Remove deprecated CallMappingExecutorService class.

79b45b5

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Migrate most of the code to the new API.

e461f0c

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Remove deprecated clearable package.

2e541b8

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Remove deprecated priority comparator mechanism (including service ca…

4f77f7d

…ching).

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Remove old abstract threadlocal base class.

eb93ed3

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          New module names for context-propagation-api and context-propagation-…

34c6d36

…core.

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Remove relocated executors package.

37f254d

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Binning the context observer. Possibly reintroduce a ContextSnapshot …

9425d34

…observer at some point.

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Restructuring into context-propagation-api / context-propagation-core…

c2d96f2

… modules.

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Remove core dependency from locale-context module.

fe24f46

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Organization: Move all Context Timers in 'timers' group.

aeb9f1c

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Organization: Move Locale Context Manager in 'managers' group.

9c44cad

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Organization: Move Slf4j Context Manager in 'managers' group.

c86124c

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>

sjoerdtalsma added 16 commits

November 11, 2024 22:08


          Organization: Move ServletRequest Context Manager in 'managers' group.

dd319c2

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Organization: Move Log4j2 Context Manager in 'managers' group.

8c06b95

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Organization: Move OpenTracing Context Manager in 'managers' group.

c18c9cf

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Organization: Move Spring Security Context Manager in 'managers' group.

2878a2d

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Remove obsolete test.

ce395b1

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Deprecate ContextManager constructors in favour of singleton provider()

9ee148e

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Minor documentation improvements.

b93214f

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Simplification of bom; remove explicit sources and javadoc classifier…

9ede75b

… dependencies.

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Simplify logging when no ContextManagers are found.

1142c57

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Simplifying ContextManagers and avoid new Lists when creating or reac…

8a18425

…tivating snapshots.

This should be a significant performance improvement.

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Simplifying ContextManagers and avoid new Lists when creating or reac…

b4dcb84

…tivating snapshots.

This should be a significant performance improvement.

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Simplification; replace ListIterator by index for-loop.

ffc4b9b

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Clean up: remove Closeable / IOException from test that were introduc…

f7e3502

…ed temporarily.

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Minor touchups.

185178c

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Replace several fully qualified names by simple names + import.

567774f

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>


          Extend ContextTimer api with thrown errors.

74c436a

Signed-off-by: Sjoerd Talsma <sjoerdtalsma@users.noreply.github.com>

sjoerdtalsma force-pushed the develop-v2 branch from 55e9d7a to 74c436a Compare

November 11, 2024 21:10

sjoerdtalsma merged commit cfc2f49 into develop

7 checks passed

sjoerdtalsma deleted the develop-v2 branch

November 11, 2024 21:14

Marcono1234 reviewed

View reviewed changes

Contributor

Marcono1234 left a comment

Sorry for the delay. I am currently not using this library, so I don't know how the changes and the new API feels for users. However, to me the changes look good and reasonable because they really simplify multiple parts.

I did not have an in-depth look at the changes, but hopefully the review comments are useful nonetheless.

readme.md Show resolved Hide resolved

...-core/src/main/java/nl/talsmasoftware/context/core/delegation/DelegatingExecutorService.java Show resolved Hide resolved

...ext-propagation-core/src/main/java/nl/talsmasoftware/context/core/function/package-info.java Show resolved Hide resolved

timers/context-timer-micrometer/pom.xml Show resolved Hide resolved

timers/context-timer-opentracing/pom.xml Show resolved Hide resolved

Contributor Author

sjoerdtalsma commented Nov 15, 2024

Sorry for the delay. I am currently not using this library, so I don't know how the changes and the new API feels for users. However, to me the changes look good and reasonable because they really simplify multiple parts.

I did not have an in-depth look at the changes, but hopefully the review comments are useful nonetheless.

@Marcono1234 thank you so much for the review and the many issues you caught!

I am contemplating on creating actual modules instead of the automatic modulenames currently used.
But those will definitely require tests with both a java8 and java 9+ test project, so still quite a bit of work, also because the serviceloader mechanism works differntly then.

Contributor

Marcono1234 commented Nov 15, 2024

Just in case you aren't aware of it, the ModiTect Maven Plugin can be used to add a module descriptor to the JAR. And if you specify <jvmVersion>9</jvmVersion>, then it will be a Multi-Release JAR, and the module-info.class should (in most cases) not cause issues for Java 8 users of your library.

But I am not sure if it is worth it adding a module descriptor instead of using automatic module names at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet