Test models #30
Merged
Test models #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tan12082001
requested changes
Dec 12, 2023
README.md
Outdated
Comment on lines
80
to
82
| bundle install | ||
| npm i | ||
|
|
There was a problem hiding this comment.
You can remove the npm i, as the dependencies will be installed through bundle install. Also let's add the instructions for generating the secret key.
Comment on lines
+91
to
+95
|
|
||
| ### Run tests | ||
| There are no tests to run. | ||
|
|
||
| <p align="right">(<a href="#readme-top">back to top</a>)</p> |
There was a problem hiding this comment.
add rspec as we just added the test suites.
Comment on lines
+123
to
+127
|
|
||
| ## 🔭 Future Features <a name="future-features"></a> | ||
|
|
||
| - None planned | ||
|
|
There was a problem hiding this comment.
It is better to add at least two future features.
tan12082001
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch's core goal is to write unit tests for all models of the App functionality.