Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Py3.9 and Py3.12 #46

Merged
merged 8 commits into from
Dec 13, 2024
Merged

Enable Py3.9 and Py3.12 #46

merged 8 commits into from
Dec 13, 2024

Conversation

yuqisun
Copy link
Collaborator

@yuqisun yuqisun commented Dec 13, 2024

All Py3.7, Py3.9 and Py3.12 work.

@yuqisun
Enable Py3.9 and Py3.12
383a2f1 
All Py3.7, Py3.9 and Py3.12 work.
@tancheng
Copy link
Owner

lol, it seems same changes in pymtl3_net are required? Maybe simple?

This was linked to issues Dec 13, 2024
Update sub-modules to latest version #39
Open
Enable testing in github actions #44
Closed
@tancheng tancheng assigned tancheng and yuqisun and unassigned tancheng Dec 13, 2024
@tancheng tancheng added the enhancement New feature or request label Dec 13, 2024
@yuqisun
Copy link
Collaborator Author

yuqisun commented Dec 13, 2024

HardFload import issue now, will retry once Fixed hardfloat git module path.#41 merged.

E ModuleNotFoundError: No module named 'VectorCGRA.fu.pymtl3_hardfloat.HardFloat'

BTW, why there're two repos:
https://github.com/tancheng/pymtl3
https://github.com/tancheng/pymtl3.1

@tancheng
Copy link
Owner

HardFload import issue now, will retry once Fixed hardfloat git module path.#41 merged.

E ModuleNotFoundError: No module named 'VectorCGRA.fu.pymtl3_hardfloat.HardFloat'

BTW, why there're two repos: https://github.com/tancheng/pymtl3 https://github.com/tancheng/pymtl3.1

Then should we use pymtl3.1@yo-struct-list-fix as it contains ur changes?

@yuqisun
Copy link
Collaborator Author

yuqisun commented Dec 13, 2024

Good now, looks git submodule update --init cannot pull submodule's submodule. Added it in VectorCGRA step again.

tancheng
tancheng approved these changes Dec 13, 2024
View reviewed changes
Copy link
Owner

@tancheng tancheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome~ Thanks!

.github/workflows/main.yml
@@ -75,7 +75,7 @@ jobs:
source ${HOME}/venv/bin/activate
pip install py==1.11.0
pip install wheel
pip install git+https://github.com/tancheng/pymtl3.git
pip install -U git+https://github.com/tancheng/pymtl3.1@yo-struct-list-fix
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, when did this become pip install git+https://github.com/tancheng/pymtl3.git... I thought it was always pip install -U git+https://github.com/tancheng/pymtl3.1@yo-struct-list-fix...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe pip install -U git+https://github.com/tancheng/pymtl3.1@yo-struct-list-fix is what we want~!

@tancheng tancheng merged commit 29a942e into tancheng:master Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancheng tancheng tancheng approved these changes

Assignees

@yuqisun yuqisun

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update sub-modules to latest version Enable testing in github actions
2 participants
@yuqisun @tancheng