Fixed float/double nan binding, binds as a nan not zero now

CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [0.12.2] - 2018-09-25
+
+### Fixed
+
+* Reverted changes to binding floats/doubles that meant they were bound as 0 when isnana() was true. They now bind correctly as a nan.
+
 ## [0.12.1] - 2018-08-28
 
 ### Fixed

README.md

@@ -76,6 +76,7 @@ The compatibility matrix with dependencies is as follows:
 
 | Libhdbpp-Cassandra Version | Libray Soname | Cassandra Version | Datastax C++ Driver | Libuv |
 |----------------------------|---------------|-------------------|---------------------|-------|
+| 0.12.2 | 7.2.2 | 2.2.11 | 2.2.1, 2.8.1 | 1.4.2 |
 | 0.12.1 | 7.2.1 | 2.2.11 | 2.2.1, 2.8.1 | 1.4.2 |
 | 0.12.0 | 7.2.0 | 2.2.11 | 2.2.1, 2.8.1 | 1.4.2 |
 | 0.11.0 | 7.1.0 | 2.2.11 | 2.2.1 | 1.4.2 |

cmake/ReleaseVersion.cmake

@@ -1,13 +1,13 @@
 # Project version
 set(LIBHDBPP_CASSANDRA_VERSION_MAJOR "0")
 set(LIBHDBPP_CASSANDRA_VERSION_MINOR "12")
-set(LIBHDBPP_CASSANDRA_VERSION_REVISION "1")
+set(LIBHDBPP_CASSANDRA_VERSION_REVISION "2")
 string(TIMESTAMP LIBHDBPP_CASSANDRA_TIMESTAMP "%Y-%m-%d %H:%M:%S")
 
 # Version the shared library
 set(LIBRARY_VERSION_MAJOR 7)
 set(LIBRARY_VERSION_MINOR 2)
-set(LIBRARY_VERSION_PATCH 1)
+set(LIBRARY_VERSION_PATCH 2)
 
 # Create the soname string
 set(LIBRARY_VERSION_STRING ${LIBRARY_VERSION_MAJOR}.${LIBRARY_VERSION_MINOR}.${LIBRARY_VERSION_PATCH})

src/TangoEventDataBinder.cpp

@@ -293,17 +293,9 @@ template <>
 void TangoEventDataBinder::statement_bind(CassStatement *statement, const string &bind_name, float val)
 {
     if (std::isnan(val))
-    {
-        /// @todo Review quiet/signalling NaN in this context
-        cass_statement_bind_float_by_name(statement, bind_name.c_str(), 0);
-
-        /*if(numeric_limits<float>::has_quiet_NaN(val) == true)
-            cass_statement_bind_float_by_name(statement, bind_name.c_str(),
-        numeric_limits<float>::quiet_NaN());
-        else
-            cass_statement_bind_float_by_name(statement, bind_name.c_str(),
-        numeric_limits<float>::signaling_NaN());*/
-    }
+        cass_statement_bind_float_by_name(statement, bind_name.c_str(), numeric_limits<float>::quiet_NaN());
+    else if (std::isinf(val))
+        cass_statement_bind_float_by_name(statement, bind_name.c_str(), numeric_limits<float>::infinity());
     else
         cass_statement_bind_float_by_name(statement, bind_name.c_str(), val);
 }
@@ -314,16 +306,9 @@ template <>
 void TangoEventDataBinder::collection_append(CassCollection *read_values_list, float val)
 {
     if (std::isnan(val))
-    {
-        /// @todo Review quiet/signalling NaN in this context
-        cass_collection_append_float(read_values_list, 0);
-
-        /*if(numeric_limits<float>::has_quiet_NaN(val) == true)
-            cass_collection_append_float(read_values_list, numeric_limits<float>::quiet_NaN());
-        else
-            cass_collection_append_float(read_values_list,
-        numeric_limits<float>::signaling_NaN());*/
-    }
+        cass_collection_append_float(read_values_list, numeric_limits<float>::quiet_NaN());
+    else if (std::isinf(val))
+        cass_collection_append_float(read_values_list, numeric_limits<float>::infinity());
     else
         cass_collection_append_float(read_values_list, val);
 }
@@ -334,17 +319,9 @@ template <>
 void TangoEventDataBinder::statement_bind(CassStatement *statement, const string &bind_name, double val)
 {
     if (std::isnan(val))
-    {
-        /// @todo Review quiet/signalling NaN in this context
-        cass_statement_bind_double_by_name(statement, bind_name.c_str(), 0);
-
-        /*if(numeric_limits<double>::has_quiet_NaN(val))
-            cass_statement_bind_double_by_name(statement, bind_name.c_str(),
-        numeric_limits<double>::quiet_NaN());
-        else
-            cass_statement_bind_double_by_name(statement, bind_name.c_str(),
-        numeric_limits<double>::signaling_NaN());*/
-    }
+        cass_statement_bind_double_by_name(statement, bind_name.c_str(), numeric_limits<double>::quiet_NaN());
+    else if (std::isinf(val))
+        cass_statement_bind_double_by_name(statement, bind_name.c_str(), numeric_limits<double>::infinity());
     else
         cass_statement_bind_double_by_name(statement, bind_name.c_str(), val);
 }
@@ -355,16 +332,9 @@ template <>
 void TangoEventDataBinder::collection_append(CassCollection *read_values_list, double val)
 {
     if (std::isnan(val))
-    {
-        /// @todo Review quiet/signalling NaN in this context
-        cass_collection_append_double(read_values_list, 0);
-
-        /*if(numeric_limits<double>::has_quiet_NaN(val))
-            cass_collection_append_double(read_values_list, numeric_limits<double>::quiet_NaN());
-        else
-            cass_collection_append_double(read_values_list,
-        numeric_limits<double>::signaling_NaN());*/
-    }
+        cass_collection_append_double(read_values_list, numeric_limits<double>::quiet_NaN());
+    else if (std::isinf(val))
+        cass_collection_append_double(read_values_list, numeric_limits<double>::infinity());
     else
         cass_collection_append_double(read_values_list, val);
 }