Fix issue #304 #421
Merged
Fix issue #304 #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `getHiddenAppsList` and refactored `getAppsList` in Utils to serve the function both. `getAppsList` can now be used to show only hidden apps, only non-hidden applications, or to show both hidden and non-hidden applications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Tanuj,
To fix issue #304, I've refactored the
getAppsListfunction inUtils.ktwith an extra variable:includeRegularApps. This code is now re-used for showing hidden apps. I've also refactored the inside of the function as well to make it a a bit less repetitive.I've also gone ahead and removed
getHiddenAppsListas it's no longer necessary.I just downloaded this app a few days and have been loving it so far 😀