Added #[Override] attribute

tarlepp · Oct 20, 2024 · 70dacd3 · 70dacd3
1 parent 9a987f9
commit 70dacd3
Show file tree

Hide file tree

Showing 34 changed files with 96 additions and 1 deletion.
diff --git a/rector.php b/rector.php
@@ -29,7 +29,7 @@
          * After that enable this directory and run rector again
          * and do that whole process again.
          */
-        //__DIR__ . '/tests',
+        __DIR__ . '/tests',
     ]);
 
     // Enable single or multiple rules with rector

diff --git a/tests/E2E/Controller/v1/Auth/LoginFailureTest.php b/tests/E2E/Controller/v1/Auth/LoginFailureTest.php
@@ -11,6 +11,7 @@
 use App\Resource\LogLoginFailureResource;
 use App\Tests\Utils\PhpUnitUtil;
 use App\Utils\JSON;
+use Override;
 use PHPUnit\Framework\Attributes\TestDox;
 use Symfony\Bundle\FrameworkBundle\KernelBrowser;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
@@ -27,6 +28,7 @@ class LoginFailureTest extends WebTestCase
     /**
      * @throws Throwable
      */
+    #[Override]
     public static function tearDownAfterClass(): void
     {
         self::bootKernel();

diff --git a/tests/E2E/Controller/v1/User/AttachUserGroupControllerTest.php b/tests/E2E/Controller/v1/User/AttachUserGroupControllerTest.php
@@ -14,6 +14,7 @@
 use App\Tests\Utils\PhpUnitUtil;
 use App\Utils\JSON;
 use Generator;
+use Override;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\TestDox;
 use Throwable;
@@ -30,6 +31,7 @@ class AttachUserGroupControllerTest extends WebTestCase
     /**
      * @throws Throwable
      */
+    #[Override]
     public static function tearDownAfterClass(): void
     {
         self::bootKernel();

diff --git a/tests/E2E/Controller/v1/User/DeleteUserControllerTest.php b/tests/E2E/Controller/v1/User/DeleteUserControllerTest.php
@@ -12,6 +12,7 @@
 use App\Tests\E2E\TestCase\WebTestCase;
 use App\Tests\Utils\PhpUnitUtil;
 use Generator;
+use Override;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\TestDox;
 use Throwable;
@@ -28,6 +29,7 @@ class DeleteUserControllerTest extends WebTestCase
     /**
      * @throws Throwable
      */
+    #[Override]
     public static function tearDownAfterClass(): void
     {
         self::bootKernel();

diff --git a/tests/E2E/Controller/v1/User/DetachUserGroupControllerTest.php b/tests/E2E/Controller/v1/User/DetachUserGroupControllerTest.php
@@ -13,6 +13,7 @@
 use App\Tests\E2E\TestCase\WebTestCase;
 use App\Tests\Utils\PhpUnitUtil;
 use Generator;
+use Override;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\TestDox;
 use Throwable;
@@ -29,6 +30,7 @@ class DetachUserGroupControllerTest extends WebTestCase
     /**
      * @throws Throwable
      */
+    #[Override]
     public static function tearDownAfterClass(): void
     {
         self::bootKernel();

diff --git a/tests/E2E/Controller/v1/UserGroup/AttachUserControllerTest.php b/tests/E2E/Controller/v1/UserGroup/AttachUserControllerTest.php
@@ -14,6 +14,7 @@
 use App\Tests\Utils\PhpUnitUtil;
 use App\Utils\JSON;
 use Generator;
+use Override;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\TestDox;
 use Throwable;
@@ -30,6 +31,7 @@ class AttachUserControllerTest extends WebTestCase
     /**
      * @throws Throwable
      */
+    #[Override]
     public static function tearDownAfterClass(): void
     {
         self::bootKernel();

diff --git a/tests/E2E/Controller/v1/UserGroup/DetachUserControllerTest.php b/tests/E2E/Controller/v1/UserGroup/DetachUserControllerTest.php
@@ -13,6 +13,7 @@
 use App\Tests\E2E\TestCase\WebTestCase;
 use App\Tests\Utils\PhpUnitUtil;
 use Generator;
+use Override;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\TestDox;
 use Throwable;
@@ -29,6 +30,7 @@ class DetachUserControllerTest extends WebTestCase
     /**
      * @throws Throwable
      */
+    #[Override]
     public static function tearDownAfterClass(): void
     {
         self::bootKernel();

diff --git a/tests/E2E/Rest/Traits/Actions/AdminActionsTest.php b/tests/E2E/Rest/Traits/Actions/AdminActionsTest.php
@@ -10,6 +10,7 @@
 
 use App\Tests\E2E\TestCase\RestTraitTestCase;
 use Generator;
+use Override;
 use function getenv;
 
 /**
@@ -20,6 +21,7 @@ class AdminActionsTest extends RestTraitTestCase
 {
     protected static string $route = '/test_admin_actions';
 
+    #[Override]
     public static function getValidUsers(): Generator
     {
         yield ['john-admin', 'password-admin'];
@@ -35,6 +37,7 @@ public static function getValidUsers(): Generator
         }
     }
 
+    #[Override]
     public static function getInvalidUsers(): Generator
     {
         if (getenv('USE_ALL_USER_COMBINATIONS') === 'yes') {

diff --git a/tests/E2E/Rest/Traits/Actions/AnonActionsTest.php b/tests/E2E/Rest/Traits/Actions/AnonActionsTest.php
@@ -10,6 +10,7 @@
 
 use App\Tests\E2E\TestCase\RestTraitTestCase;
 use Generator;
+use Override;
 use function getenv;
 
 /**
@@ -23,6 +24,7 @@ class AnonActionsTest extends RestTraitTestCase
     /**
      * @noinspection PhpMissingParentCallCommonInspection
      */
+    #[Override]
     public function testThatCountRouteDoesNotAllowInvalidUser(
         ?string $u = null,
         ?string $p = null,
@@ -34,6 +36,7 @@ public function testThatCountRouteDoesNotAllowInvalidUser(
     /**
      * @noinspection PhpMissingParentCallCommonInspection
      */
+    #[Override]
     public function testThatRootRouteDoesNotAllowInvalidUser(
         ?string $u = null,
         ?string $p = null,
@@ -45,6 +48,7 @@ public function testThatRootRouteDoesNotAllowInvalidUser(
     /**
      * @noinspection PhpMissingParentCallCommonInspection
      */
+    #[Override]
     public function testThatUuidRouteWithIdDoesNotAllowInvalidUser(
         string $uuid = '',
         ?string $u = null,
@@ -57,6 +61,7 @@ public function testThatUuidRouteWithIdDoesNotAllowInvalidUser(
     /**
      * @noinspection PhpMissingParentCallCommonInspection
      */
+    #[Override]
     public function testThatIdsRouteDoesNotAllowInvalidUser(
         ?string $u = null,
         ?string $p = null,
@@ -65,6 +70,7 @@ public function testThatIdsRouteDoesNotAllowInvalidUser(
         static::markTestSkipped('There isn\'t invalid users, so cannot test this.');
     }
 
+    #[Override]
     public static function getValidUsers(): Generator
     {
         yield [null, null];
@@ -88,6 +94,7 @@ public static function getValidUsers(): Generator
     /**
      * @psalm-suppress InvalidReturnType
      */
+    #[Override]
     public static function getInvalidUsers(): Generator
     {
         yield from [];

diff --git a/tests/E2E/Rest/Traits/Actions/AuthenticatedActionsTest.php b/tests/E2E/Rest/Traits/Actions/AuthenticatedActionsTest.php
@@ -10,6 +10,7 @@
 
 use App\Tests\E2E\TestCase\RestTraitTestCase;
 use Generator;
+use Override;
 use function getenv;
 
 /**
@@ -20,6 +21,7 @@ class AuthenticatedActionsTest extends RestTraitTestCase
 {
     protected static string $route = '/test_authenticated_actions';
 
+    #[Override]
     public static function getValidUsers(): Generator
     {
         yield ['john', 'password'];
@@ -43,6 +45,7 @@ public static function getValidUsers(): Generator
         }
     }
 
+    #[Override]
     public static function getInvalidUsers(): Generator
     {
         yield [null, null];

diff --git a/tests/E2E/Rest/Traits/Actions/LoggedActionsTest.php b/tests/E2E/Rest/Traits/Actions/LoggedActionsTest.php
@@ -10,6 +10,7 @@
 
 use App\Tests\E2E\TestCase\RestTraitTestCase;
 use Generator;
+use Override;
 use function getenv;
 
 /**
@@ -20,6 +21,7 @@ class LoggedActionsTest extends RestTraitTestCase
 {
     protected static string $route = '/test_logged_actions';
 
+    #[Override]
     public static function getValidUsers(): Generator
     {
         yield ['john-logged', 'password-logged'];
@@ -41,6 +43,7 @@ public static function getValidUsers(): Generator
         }
     }
 
+    #[Override]
     public static function getInvalidUsers(): Generator
     {
         yield [null, null];

diff --git a/tests/E2E/Rest/Traits/Actions/RootActionsTest.php b/tests/E2E/Rest/Traits/Actions/RootActionsTest.php
@@ -10,6 +10,7 @@
 
 use App\Tests\E2E\TestCase\RestTraitTestCase;
 use Generator;
+use Override;
 use function getenv;
 
 /**
@@ -20,12 +21,14 @@ class RootActionsTest extends RestTraitTestCase
 {
     protected static string $route = '/test_root_actions';
 
+    #[Override]
     public static function getValidUsers(): Generator
     {
         yield ['john-root', 'password-root'];
         yield ['john.doe-root@test.com', 'password-root'];
     }
 
+    #[Override]
     public static function getInvalidUsers(): Generator
     {
         if (getenv('USE_ALL_USER_COMBINATIONS') === 'yes') {

diff --git a/tests/E2E/Rest/Traits/Actions/UserActionsTest.php b/tests/E2E/Rest/Traits/Actions/UserActionsTest.php
@@ -10,6 +10,7 @@
 
 use App\Tests\E2E\TestCase\RestTraitTestCase;
 use Generator;
+use Override;
 use function getenv;
 
 /**
@@ -20,6 +21,7 @@ class UserActionsTest extends RestTraitTestCase
 {
     protected static string $route = '/test_user_actions';
 
+    #[Override]
     public static function getValidUsers(): Generator
     {
         yield ['john-user', 'password-user'];
@@ -37,6 +39,7 @@ public static function getValidUsers(): Generator
         }
     }
 
+    #[Override]
     public static function getInvalidUsers(): Generator
     {
         yield [null, null];

diff --git a/tests/E2E/Rest/src/Resource/ResourceForLifeCycleTests.php b/tests/E2E/Rest/src/Resource/ResourceForLifeCycleTests.php
@@ -13,6 +13,7 @@
 use App\Entity\Role as Entity;
 use App\Repository\RoleRepository as Repository;
 use App\Rest\RestResource;
+use Override;
 use Symfony\Component\HttpKernel\Exception\HttpException;
 
 /**
@@ -43,6 +44,7 @@ public function __construct(
         parent::__construct($repository);
     }
 
+    #[Override]
     public function afterFindOne(string &$id, ?EntityInterface $entity = null): void
     {
         parent::afterFindOne($id, $entity);

diff --git a/tests/E2E/TestCase/RestTraitTestCase.php b/tests/E2E/TestCase/RestTraitTestCase.php
@@ -10,6 +10,7 @@
 
 use App\Tests\Utils\PhpUnitUtil;
 use Generator;
+use Override;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\TestDox;
 use Symfony\Component\HttpFoundation\Request;
@@ -33,6 +34,7 @@ abstract class RestTraitTestCase extends WebTestCase
     /**
      * @throws Throwable
      */
+    #[Override]
     public static function tearDownAfterClass(): void
     {
         self::bootKernel();

diff --git a/tests/E2E/TestCase/WebTestCase.php b/tests/E2E/TestCase/WebTestCase.php
@@ -8,6 +8,7 @@
 
 namespace App\Tests\E2E\TestCase;
 
+use Override;
 use Symfony\Bundle\FrameworkBundle\KernelBrowser;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase as BaseWebTestCase;
 use Throwable;
@@ -25,6 +26,7 @@ abstract class WebTestCase extends BaseWebTestCase
     /**
      * @codeCoverageIgnore
      */
+    #[Override]
     public static function setUpBeforeClass(): void
     {
         parent::setUpBeforeClass();
@@ -35,6 +37,7 @@ public static function setUpBeforeClass(): void
     /**
      * @codeCoverageIgnore
      */
+    #[Override]
     public static function tearDownAfterClass(): void
     {
         parent::tearDownAfterClass();

diff --git a/tests/Functional/Repository/HealthzRepositoryTest.php b/tests/Functional/Repository/HealthzRepositoryTest.php
@@ -12,6 +12,7 @@
 use App\Tests\Utils\PhpUnitUtil;
 use DateTimeImmutable;
 use DateTimeZone;
+use Override;
 use PHPUnit\Framework\Attributes\Depends;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Throwable;
@@ -25,6 +26,7 @@ class HealthzRepositoryTest extends KernelTestCase
     /**
      * @throws Throwable
      */
+    #[Override]
     public static function tearDownAfterClass(): void
     {
         self::bootKernel();

diff --git a/tests/Functional/Repository/RoleRepositoryTest.php b/tests/Functional/Repository/RoleRepositoryTest.php
@@ -10,6 +10,7 @@
 
 use App\Repository\RoleRepository;
 use App\Tests\Utils\PhpUnitUtil;
+use Override;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Throwable;
 
@@ -22,6 +23,7 @@ class RoleRepositoryTest extends KernelTestCase
     /**
      * @throws Throwable
      */
+    #[Override]
     public static function tearDownAfterClass(): void
     {
         self::bootKernel();

diff --git a/tests/Functional/Repository/UserRepositoryTest.php b/tests/Functional/Repository/UserRepositoryTest.php
@@ -11,6 +11,7 @@
 use App\Entity\User;
 use App\Repository\UserRepository;
 use App\Tests\Utils\PhpUnitUtil;
+use Override;
 use PHPUnit\Framework\Attributes\Depends;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Throwable;
@@ -27,6 +28,7 @@ class UserRepositoryTest extends KernelTestCase
     /**
      * @throws Throwable
      */
+    #[Override]
     public static function tearDownAfterClass(): void
     {
         self::bootKernel();