Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PHP 8.0 warnings #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix PHP 8.0 warnings #74

wants to merge 1 commit into from

Conversation

madu696
Copy link

@madu696 madu696 commented Jun 22, 2021

Using phpBB 3.3.4 and PHP 8.0 I have noticed so far 2 warnings.

[phpBB Debug] PHP Warning: in file [ROOT]/ext/tas2580/seourls/event/listener.php on line 439: Undefined array key "post_id" #69 (when there is no posts in topic)

[phpBB Debug] PHP Warning: in file [ROOT]/ext/tas2580/seourls/event/listener.php on line 245 and 246 Undefined array key "active_f_row" and Undefined array key "active_t_row" + Trying to access array offset on value of type bool/null (when new user has no post/topic).

Copy link

@zetrader zetrader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix works fine with phpbb 3.3.4 and php 8.0.12

@zetrader
Copy link

zetrader commented Apr 30, 2022

I've tried with phpbb 3.3.7 and php 8.1.5, the fix still works fine.

@zetrader
Copy link

zetrader commented Aug 25, 2022

It works but i've noticed something that didn't happen before with php 8.0 or 8.1, when there is a second page for a topic, the link becomes :
my-topic.html?start=10 instead of my-topic.html-s10.html, and then if we click on the first page, the link is now viewtopic.php?t=x like there's no rewrite, but in source code, the canonical url is still my-topic.html.
Any way to fix this?

EDIT : i've tried without fix, phpbb 3.3.8 and php 8.1 it's the same bug, so the fix is not the problem, i guess the script has a new pagination problem of the topics with php 8.0 and php 8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants