Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListView: virtual keyboard navigation component #393

Merged
merged 2 commits into from
Aug 24, 2023
Merged

ListView: virtual keyboard navigation component #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d89488
fix(ListView): typedef of component handlers
LamaEats Aug 24, 2023
c6f0d87
chore(ListView): any is valid type for item value
awinogradov Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/ListView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@ import { useMounted } from '../hooks/useMounted';
import { useKeyPress } from '../hooks';

interface ListViewProps {
onClick?: <T>(value: T) => void;
onKeyboardClick?: <T>(value: T) => void;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
onClick?: (value: any) => void;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
onKeyboardClick?: (value: any) => void;
children: React.ReactNode;
}

Expand Down
2 changes: 1 addition & 1 deletion src/stories/ListItem.stories.tsx → src/stories/ListView.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

export const Default: StoryFn = () => {
return (
<ListView>
<ListView onClick={(item) => console.log(item)} onKeyboardClick={(item) => console.log(item)}>

Check warning on line 19 in src/stories/ListView.stories.tsx

View workflow job for this annotation

GitHub Actions / build 

Unexpected console statement

Check warning on line 19 in src/stories/ListView.stories.tsx

View workflow job for this annotation

GitHub Actions / build 

Unexpected console statement
<Table width={200} gap={10}>
{data.slice(0, 5).map((item) => (
<ListViewItem
Expand Down
Loading