Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken weight field validation in CriteriaForm #1438

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Broken weight field validation in CriteriaForm #1438

merged 1 commit into from
Aug 3, 2023

Conversation

LamaEats
Copy link
Contributor

@LamaEats LamaEats commented Aug 3, 2023

Now weight field validation works correctly
Passed value will be checks by validation function
If value is empty then validating process doesn't runs

PR includes

  • Bug Fix

Related issues

Resolve #1437

QA Instructions, Screenshots, Recordings

  1. Open add or edit criteria
  2. Try to pass value into weight filed
    1. if value less or greater of available weights interval then behind of the input shows error message
    2. By clear value in an input validating message will be dismiss

@LamaEats LamaEats merged commit 0200ca1 into main Aug 3, 2023
2 checks passed
@LamaEats LamaEats deleted the issues/1437 branch August 3, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awinogradov awinogradov awinogradov approved these changes

@9teen90nine 9teen90nine 9teen90nine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken weight field validation in CriteriaForm
3 participants
@LamaEats @awinogradov @9teen90nine