Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite CommentForm w/o project deps, like goalId and trpc #1469

Merged
merged 8 commits into from
Aug 8, 2023
Merged

Rewrite CommentForm w/o project deps, like goalId and trpc #1469

merged 8 commits into from
Aug 8, 2023

Conversation

awinogradov
Copy link
Contributor

PR includes

  • Refactor
  • DX

Related issues

Resolve #1433
Resolve #1434

Related issues #1251

9teen90nine
9teen90nine reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@9teen90nine 9teen90nine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/hooks/useDateViewType.ts Outdated Show resolved Hide resolved
@awinogradov awinogradov marked this pull request as ready for review August 8, 2023 12:30
@awinogradov awinogradov merged commit 1e2bd1d into main Aug 8, 2023
2 checks passed
@awinogradov awinogradov deleted the issues/1433 branch August 8, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9teen90nine 9teen90nine 9teen90nine approved these changes

@DenisVorop DenisVorop DenisVorop approved these changes

@LamaEats LamaEats Awaiting requested review from LamaEats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin comment after achivements criteria and deps Rewrite CommentForm w/o project deps, like goalId and trpc
3 participants
@awinogradov @9teen90nine @DenisVorop