Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImagePreview closes GoalPreview on ESC #1518

Merged
merged 1 commit into from
Aug 16, 2023
Merged

ImagePreview closes GoalPreview on ESC #1518

merged 1 commit into from
Aug 16, 2023

Conversation

Troff8
Copy link
Contributor

@Troff8 Troff8 commented Aug 14, 2023 •
edited
Loading

PR includes

  • Bug Fix

Related issues

Resolve #1507

@Troff8 Troff8 marked this pull request as ready for review August 15, 2023 20:49
awinogradov
awinogradov requested changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@awinogradov awinogradov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

You have commits with a non github account

src/components/ImageFullScreen.tsx Outdated Show resolved Hide resolved
@awinogradov
Copy link
Contributor

Also, in description of PR you set feature but this is bug fix. Same in your commit message.

@Troff8 Troff8 merged commit 12ece5b into main Aug 16, 2023
3 checks passed
@Troff8 Troff8 deleted the issues/1507 branch August 16, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awinogradov awinogradov awinogradov approved these changes

@9teen90nine 9teen90nine 9teen90nine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImagePreview closes GoalPreview on ESC
3 participants
@Troff8 @awinogradov @9teen90nine