Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat biom tax table #134

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Feat biom tax table #134

merged 2 commits into from
Aug 24, 2023

Conversation

Midnighter
Copy link
Contributor

@Midnighter Midnighter requested a review from a team August 23, 2023 16:12
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.02% ⚠️

Comparison is base (82477a6) 85.89% compared to head (1dd4cf2) 85.87%.

❗ Current head 1dd4cf2 differs from pull request most recent head 367257f. Consider uploading reports for the commit 367257f to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #134      +/-   ##
==========================================
- Coverage   85.89%   85.87%   -0.02%     
==========================================
  Files         114      114              
  Lines        1772     1791      +19     
  Branches      319      325       +6     
==========================================
+ Hits         1522     1538      +16     
- Misses        202      205       +3     
  Partials       48       48              
Files Changed Coverage Δ
...table_writer/biom_wide_observation_table_writer.py 77.27% <0.00%> (-12.21%) ⬇️
src/taxpasta/domain/service/taxonomy_service.py 100.00% <100.00%> (ø)
...tructure/domain/service/taxopy_taxonomy_service.py 75.67% <100.00%> (+3.51%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@maxibor maxibor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Midnighter Midnighter merged commit 8220105 into dev Aug 24, 2023
13 checks passed
@Midnighter Midnighter deleted the feat-biom-tax-table branch August 24, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add a taxonomy table to the BIOM output
3 participants