Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(role-settings): remove conditional titles for role power level settings #1050

Open
wants to merge 2 commits into
base: develop_tchap
Choose a base branch
from
Open

feat(role-settings): remove conditional titles for role power level settings #1050

wants to merge 2 commits into from

Conversation

MarcWadai
Copy link
Contributor

issue #1017

@MarcWadai MarcWadai marked this pull request as draft June 24, 2024 17:13
@MarcWadai MarcWadai force-pushed the 1017-roles-power-settings-rename-titles branch from 501b6ce to 4ef6a8e Compare June 25, 2024 09:36
@MarcWadai MarcWadai marked this pull request as ready for review June 25, 2024 09:44
@MarcWadai MarcWadai force-pushed the 1017-roles-power-settings-rename-titles branch 2 times, most recently from 82ce3bc to 3136e9c Compare June 25, 2024 15:10
NicolasBuquet
NicolasBuquet reviewed Jun 25, 2024
View reviewed changes
Copy link

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

modules/tchap-translations/tchap_translations.json Show resolved Hide resolved
...pendencies/matrix-react-sdk/src/components/views/settings/tabs/room/RolesRoomSettingsTab.tsx Show resolved Hide resolved
@MarcWadai MarcWadai force-pushed the 1017-roles-power-settings-rename-titles branch from 3136e9c to 251cd6f Compare June 25, 2024 15:24
@MarcWadai MarcWadai force-pushed the 1017-roles-power-settings-rename-titles branch from 251cd6f to 0c4971b Compare July 2, 2024 16:57
@MarcWadai
Copy link
Contributor Author

@NicolasBuquet @yostyle
The double beacon value is not present in element because its an addition on tchap side to allow user to share there location by default. See tchapgouv/synapse-room-access-rules#3
So at the end, I removed visually the duplicate value and changed both of the values when BEACON_INFO is changed

NicolasBuquet
NicolasBuquet reviewed Jul 9, 2024
View reviewed changes
Copy link

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le principe est ok (vu ensemble).
Le changement d'un powerLevel sur NAME devrait changer le powerLevel ALT_NAME.
Cela ne semble pas être le cas.
Tester en inversant l'ordre des changements pour voir si le backend ne prend en compte que le premier changement.
Si c'est le cas, prévoir d'envoyer 2 requêtes de changement distinctes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasBuquet NicolasBuquet NicolasBuquet left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcWadai @NicolasBuquet