Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define as buffer-local minor mode. #12

Open
hbin opened this issue Feb 3, 2015 · 1 comment
Open

Define as buffer-local minor mode. #12

hbin opened this issue Feb 3, 2015 · 1 comment

Comments

@hbin
Copy link

hbin commented Feb 3, 2015

Hi boyw165,

hl-anything is great, thank you for your effort.

I find that you create it as global minor mode rather than buffer-local. https://github.com/boyw165/hl-anything/blob/master/hl-anything.el#L694

As manual specified, if you set global non-nil the minor mode will be global rather than buffer-local.

I suggest that you can create it as buffer-local minor mode, and create the global-mode by define-globalized-minor-mode.

Previously, I create a minor mode named smart-shift by this way. Just FYI https://github.com/hbin/smart-shift/blob/master/smart-shift.el#L261

@tcw165
Copy link
Owner

tcw165 commented Feb 3, 2015

Hi @hbin

Seems like it's more than a simple transfer from global-mode to local-mode (and produce an inherited global-mode) due to hl-anything's features. So I'll take it later. Thanks. 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants