Skip to content

Commit

Permalink
ci: Add GH action to check for TSC votes on core dataset changes (ked…
Browse files Browse the repository at this point in the history
…ro-org#896)

* Add GH action to check for TSC votes on core dataset changes
* Ignore TSC vote action in gatekeeper
* Trigger TSC vote action only on changes in core dataset

---------

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: tdhooghe <thomas_dhooghe@mckinsey.com>
  • Loading branch information
merelcht authored and tdhooghe committed Oct 21, 2024
1 parent 388f455 commit 3c85b1f
Show file tree
Hide file tree
Showing 3 changed files with 51 additions and 0 deletions.
36 changes: 36 additions & 0 deletions .github/reviewers.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
{
"teams": {
"everyone": {
"description": "A team that contains all TSC members.",
"users": [
"ankatiyar",
"astrojuanlu",
"datajoely",
"deepyaman",
"DimedS",
"Galileo-Galilei",
"Huongg",
"idanov",
"jitu5",
"lrcouto",
"marrrcin",
"merelcht",
"noklam",
"rashidakanchwala",
"ravi-kumar-pilla",
"SajidAlamQB",
"sbrugman",
"stephkaiser",
"tynandebold",
"yetudada"
]
}
},
"reviewers": {
"kedro-datasets/kedro_datasets/": {
"description": "Require at least 1/2 TSC approval on new core dataset contributions.",
"teams": ["everyone"],
"requiredApproverCount": 10
}
}
}
14 changes: 14 additions & 0 deletions .github/workflows/check-tsc-vote.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: Required Reviews
on:
pull_request:
paths:
- 'kedro-datasets/kedro_datasets/*'
jobs:
required-reviews:
name: Required Reviews
runs-on: ubuntu-latest
steps:
- name: required-reviewers
uses: theoremlp/required-reviews@v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
1 change: 1 addition & 0 deletions .github/workflows/merge-gatekeeper.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
timeout: 2400
interval: 30
ignored: 'Required Reviews'

0 comments on commit 3c85b1f

Please sign in to comment.