-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI 이슈 수정 #64
UI 이슈 수정 #64
Conversation
dogdduddy
commented
Aug 27, 2023
- 바텀 내비게이션 만큼 Layout 뜨는 문제 수정
- nickName 크래시 해결
- 바텀 내비게이션 애니메이션만 있고, View 영역은 존재해서 Layout이 뜨는 문제 -> Visibility Gone 처리 - Gone 처리 시 애니메이션 없이 사라지는 문제 -> 애니메이션 종료 후 Gone 처리
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
val myAnimationListener: Animator.AnimatorListener = | ||
object : Animator.AnimatorListener { | ||
override fun onAnimationStart(p0: Animator) {} | ||
override fun onAnimationEnd(p0: Animator) { | ||
|
||
binding.bottomNavigationView.visibility = View.GONE | ||
} | ||
|
||
override fun onAnimationCancel(p0: Animator) {} | ||
override fun onAnimationRepeat(p0: Animator) {} | ||
} | ||
binding.bottomNavigationView.slideDown(endListener = myAnimationListener) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
view 자체가 gone 이 안돼서 생겼던 문제군요!
repeatWhenUiStarted { | ||
viewModel.nicknameState.collectLatest { | ||
setToolbarTitle(it) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요기는 뭐가 문제였던 건가요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로직 자체가 달라지긴 했는데
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nickName 없어도 적용하려다가 크래시 나는 부분이에욥.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 근데 요기는 원래 닉네임이 무조건 있어야하지않어요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Info API로 받아온 닉네임을 표현해주는 부분이라 타이틀이 보여지는 시간차가 생길 순 있어도, API 자체가 실패한 게 아니면 Title에 적용 되지 않을까 합니당.
그리고 커멘트 달았는데 Bitmap 사용하고 recycle 안 해도 괜ㅊ낳나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉 코멘트가 안달려있어요..!!(수정해서 적용해놨습니다)
수정된 방식에서도 닉네임이 없으면 크래시가 나지 않나요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사실 이름이 없는게 문제 상황인거죠
그리고 그렇다해도 info api 핸들링으로 처리하면 문제가 없을 것 같습니다.
title은 null이 문제지 미입력이 문제는 아닌 것 같아서요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네네 맞아요 크래시 해결하셨다고 해서 말씀드려봤습니다!
기존에 크래시 났던 이유가 저희 기능 문제가 아니고 제 구글 계정이 회원가입이 제대로 안된 상태로 로그인돼서 닉네임이 없었던게 문제였던 상황이었어요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그 뷰분은 info쪽에서 크래시 나는지 백엔드에 요청드려서 테스트해볼게용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네넵..!! 감사합니당