Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elevator #13

Merged
merged 38 commits into from
Jan 28, 2024
Merged

Elevator #13

merged 38 commits into from
Jan 28, 2024

Conversation

MatthewChoulas
Copy link
Contributor

No description provided.

nbhog and others added 30 commits January 12, 2024 18:49
@nbhog
elevatorIO
92a0dfb
@nbhog
started Elevator.kt file
e6b176c
@CodingMaster121
Reformatted Code
1af374c
@CodingMaster121
Added Elevator.kt variables
b161b28
@CodingMaster121
Added init for Elevator.kt
6946de7
@nbhog
finished elevator.kt file
f5faca7
@nbhog
started hardware code
27a2573
@nbhog
started kraken hardware file
51c66ed
@nbhog
finished hardware file
bd74ffe
@Shom770 @MatthewChoulas
toLog IO file
3a37208
@MatthewChoulas
Finished IntakeIO
d1711e7
@fyrhanish @MatthewChoulas
Began intake file
983021a
@MatthewChoulas
Added state machine code
4a0a407
@MatthewChoulas
Removed arm from intake code
176d5a0
@Shom770 @MatthewChoulas
intake code is finished
2bed455
@Shom770 @MatthewChoulas
remove encoder offset
d7203ca
@MatthewChoulas
Removed zero state
cc19b01
@NeonCoal @MatthewChoulas
Initial commit for IntakeIOSim
1e29138 
plus syntax changes stake --> state and OPEN_LOOP_REQUEST --> OPEN_LOOP
@NeonCoal @MatthewChoulas
update constants
8898d8e
@NeonCoal @MatthewChoulas
stuff
dc978d6
@NeonCoal @MatthewChoulas
fixing sim
9244539
@Shom770 @MatthewChoulas
initial commit
e496d45
@Shom770 @MatthewChoulas
current changes so far
1b0397f
@Shom770 @MatthewChoulas
working dt:
95035f5
@sswadkar @MatthewChoulas
add wrapper class on velocity and position voltage requests
7164749
@sswadkar @MatthewChoulas
update falconutils to 1.1.28
6de3656
@MatthewChoulas
rebase
eef9240
@MatthewChoulas
rebase
8ed8301
@MatthewChoulas
fix more rebase
8da8ad1
@MatthewChoulas
fix phoenix wrapper issues
81472cb
sswadkar
sswadkar requested changes Jan 20, 2024
View reviewed changes
Copy link
Member

@sswadkar sswadkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. can we remove the drivetrain stuff from this branch as well? idk it might not be worth it anymore but it's going to make merging hard.

src/main/kotlin/com/team4099/robot2023/subsystems/elevator/ElevatorIOKraken.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/team4099/robot2023/subsystems/elevator/ElevatorIOKraken.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/team4099/robot2023/subsystems/elevator/ElevatorIOKraken.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/team4099/robot2023/subsystems/elevator/ElevatorIOKraken.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/team4099/robot2023/subsystems/elevator/ElevatorIONEO.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/team4099/robot2023/config/constants/ElevatorConstants.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/team4099/robot2023/config/constants/ElevatorConstants.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/team4099/robot2023/config/constants/ElevatorConstants.kt Outdated Show resolved Hide resolved
simgui.json Outdated Show resolved Hide resolved
src/main/kotlin/com/team4099/lib/phoenix6/PositionVoltage.kt Outdated Show resolved Hide resolved
@MatthewChoulas MatthewChoulas merged commit e15f527 into main Jan 28, 2024
1 check failed
@00magikarp 00magikarp deleted the elevator branch July 16, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodingMaster121 CodingMaster121 CodingMaster121 left review comments

@sswadkar sswadkar sswadkar requested changes

@AlphaPranav9102 AlphaPranav9102 Awaiting requested review from AlphaPranav9102

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MatthewChoulas @sswadkar @CodingMaster121 @nbhog @Shom770 @fyrhanish @NeonCoal @Aagames1