Chi 1434 move redux constants #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate to prevent as many dependency issues in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Do not review until #1728 is merged
Description
This PR moves the constants we use for the various redux namespaces into their own file
Them being defined in the same file as the root state was causing circular dependency headaches, because every time you used any of these constants, you have to pull in the whole state handling code hierarchy
Now these constants can be used in isolation.
We should probably start deprecating the use of these in favour of using the correct types now we are in TS land, but this solves the immediate issue.
There aren't really any 'real' changes here, aside from a little bit of tidying the edits are all related to moving those constants
Checklist
Related Issues
Fixes #....
Verification steps