Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHI-1994: HRM form refactor #1732

Merged
merged 4 commits into from
Oct 19, 2023
Merged

CHI-1994: HRM form refactor #1732

merged 4 commits into from
Oct 19, 2023

Conversation

stephenhand
Copy link
Collaborator

Description

Minor refactor to used mapped dispatchers in TabbedForms.tsx & HrmForm.tsx,
Replaced direct save with redux action in HrmForm.tsx

Checklist

  • Corresponding issue has been opened
  • N/A New tests added
  • N/A Feature flags added
  • N/A Strings are localized
  • Tested for chat contacts
  • Tested for call contacts

Related Issues

CHI-994

Verification steps

None required, automated tests should cover it

@stephenhand stephenhand mentioned this pull request Oct 18, 2023
Merged
4 tasks
murilovmachado
murilovmachado approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@murilovmachado murilovmachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've skimmed through it, end everything looks good to me!

@stephenhand stephenhand merged commit f41edf8 into master Oct 19, 2023
8 checks passed
@stephenhand stephenhand deleted the CHI-1994-form_refactor branch October 19, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murilovmachado murilovmachado murilovmachado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenhand @murilovmachado