Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned conversation media types with backend expectations #1738

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

GPaoloni
Copy link
Collaborator

Description

This PR fixes an existing issue where saving contacts fails with 500 error status code.
The issue arises because the conversation medias in the create contact payload were using the new format, but bundled in the legacy rawForm.conversationMedia property. This PR fixes the issue by moving this to the root of the create contact payload, where the backend expects the new format to be present.

Verification steps

  • Start a new local HRM server in branch v2.10-rc.
  • Start a new development Flex instance using this branch.
  • Start a new chat contact and try saving it: it should succeed.
  • Test that everything else around the fixes recently included in the RC branch are still working as intended.

Copy link
Collaborator

@stephenhand stephenhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I made a lot of the same changes on master,

@GPaoloni GPaoloni merged commit 787caba into v2.10-rc Oct 19, 2023
8 checks passed
@GPaoloni GPaoloni deleted the gian_fix-v2.10.4-qa.1 branch October 19, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants