CHI-1994: Search in a modal modal #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # plugin-hrm-form/src/components/search/index.tsx # plugin-hrm-form/src/components/tabbedForms/TabbedForms.tsx
# Conflicts: # plugin-hrm-form/src/components/caseList/CaseListTable.tsx # plugin-hrm-form/src/components/search/SearchResults/index.tsx
|
I think the E2E test failure might be due to the E2E chatbot change @acedeywin? Looks like the chatbot never starts and the chat goes straight into the queue, which breaks the test |
6 tasks
This was referenced Oct 25, 2023
Merged
murilovmachado
approved these changes
Oct 26, 2023
Comment on lines
+190
to
194
| const checkForEdits = (closeModal: boolean) => { | ||
| if (isEqual(workingCopy, savedForm)) { | ||
| closeActions(); | ||
| } else setOpenDialog(true); | ||
| closeActions(closeModal); | ||
| } else setDialogState(closeModal ? DialogState.OpenForClose : DialogState.OpenForBack); | ||
| }; |
There was a problem hiding this comment.
My brain goes crazy when I see if clause using brackets and the else doesn't. I know this bracket choice was already in the code, so feel free to ignore this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO: styling is only partially complete
Checklist
Related Issues
CHI-1994
Verification steps