Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHI-1994: unit tests #1755

Merged
merged 6 commits into from
Nov 2, 2023
Merged

CHI-1994: unit tests #1755

merged 6 commits into from
Nov 2, 2023

Conversation

stephenhand
Copy link
Collaborator

@stephenhand stephenhand commented Oct 25, 2023 •
edited
Loading

Description

Unit tests for new routing reducer logic & component helpers

Checklist

  • Corresponding issue has been opened
  • New tests added
  • N/A Feature flags added
  • N/A Strings are localized
  • N/A Tested for chat contacts
  • N/A Tested for call contacts

Related Issues

CHI-1994

Verification steps

Tests pass!

acedeywin
acedeywin approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@acedeywin acedeywin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenhand stephenhand merged commit 4cc89d5 into master Nov 2, 2023
8 checks passed
@stephenhand stephenhand deleted the CHI-1994-unit_tests branch November 2, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acedeywin acedeywin acedeywin approved these changes

@murilovmachado murilovmachado Awaiting requested review from murilovmachado

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenhand @acedeywin