Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHI-2223: Unsaved confirm dialog on close POC #1758

Merged
merged 8 commits into from
Nov 2, 2023

Conversation

stephenhand
Copy link
Collaborator

@stephenhand stephenhand commented Oct 25, 2023

Merge #1745 before review

Description

Whilst it might not capture all the edge cases, this demonstrates a simple & robust

Related Issues

CHI-2223

Verification steps

Edit various aspects of cases / contacts and close the browser window, verify the standard browser confirm dialog appears when edits are unsaved

# Conflicts:
#	plugin-hrm-form/src/components/CustomCRMContainer.tsx
Copy link
Contributor

@murilovmachado murilovmachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and it worked just fine!

@stephenhand stephenhand merged commit aedfdcf into master Nov 2, 2023
8 checks passed
@stephenhand stephenhand deleted the CHI-2223-unsaved_dialog branch November 2, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants