Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: profile state hook cleanup #1932

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

robert-bo-davis
Copy link
Collaborator

@robert-bo-davis robert-bo-davis commented Dec 11, 2023

Primary reviewer:

Description

This splits the profile state hooks into separate files and eliminates the overly complicated and less than explicit reuse of hooks within hooks.

Checklist

  • Corresponding issue has been opened
  • New tests added
  • Feature flags added
  • Strings are localized
  • Tested for chat contacts
  • Tested for call contacts

Related Issues

Fixes #....

Verification steps

@robert-bo-davis robert-bo-davis marked this pull request as ready for review December 12, 2023 13:24
Copy link
Collaborator

@mythilytm mythilytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-bo-davis robert-bo-davis merged commit 0b628c0 into master Dec 14, 2023
8 checks passed
@robert-bo-davis robert-bo-davis deleted the bo/reafactor/profileHooksCleanup branch December 14, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants