Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHI-2255: Draft status indicators #1945

Merged
merged 9 commits into from
Dec 28, 2023
Merged

CHI-2255: Draft status indicators #1945

merged 9 commits into from
Dec 28, 2023

Conversation

stephenhand
Copy link
Collaborator

@stephenhand stephenhand commented Dec 15, 2023

Description

Added status indicators to draft contacts in search results, contact details and the case details, as indicated in these mocks: https://www.figma.com/file/0WuaCgB0JEV819kbXEWkE2/Draft-Mode?type=design&node-id=129-19773&mode=design&t=O2X3YgUu32BjEZK2-0

Checklist

  • Corresponding issue has been opened
  • N/A New tests added
  • Feature flags added
  • Strings are localized
  • Tested for chat contacts
  • Tested for call contacts

Related Issues

CHI-2255

Verification steps

See jira ticket

…tact details & timeline contacts that are still drafts
# Conflicts:
#	plugin-hrm-form/src/components/caseMergingBanners/ContactAddedToCaseBanner.tsx
#	plugin-hrm-form/src/components/caseMergingBanners/ContactRemovedFromCaseBanner.tsx
#	plugin-hrm-form/src/components/contact/ContactDetailsHome.tsx
Copy link
Contributor

@murilovmachado murilovmachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@@ -154,6 +156,8 @@ const ContactDetailsHome: React.FC<Props> = function ({
caseId,
} = savedContact;

const isDraft = !savedContact.finalizedAt;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good when things are this simple 🙏

# Conflicts:
#	plugin-hrm-form/src/components/case/timeline/Timeline.tsx
#	plugin-hrm-form/src/components/caseMergingBanners/AddToCaseBanner.tsx
#	plugin-hrm-form/src/components/caseMergingBanners/ContactRemovedFromCaseBanner.tsx
#	plugin-hrm-form/src/components/search/CasePreview/CaseHeader.tsx
#	plugin-hrm-form/src/components/search/CasePreview/index.tsx
#	plugin-hrm-form/src/components/search/ContactPreview/ContactHeader.tsx
#	plugin-hrm-form/src/components/search/ContactPreview/index.tsx
#	plugin-hrm-form/src/components/search/styles.tsx
#	plugin-hrm-form/src/styles/HrmStyles.tsx
@stephenhand stephenhand merged commit 043186d into master Dec 28, 2023
8 checks passed
@stephenhand stephenhand deleted the CHI-2255-draft_status branch December 28, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants