CHI-2138: Removed twilio sync based transfers #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nised transfer code slightly, updated tests
murilovmachado
approved these changes
Dec 20, 2023
Comment on lines
+38
to
+40
| if (savedContact.caseId) { | ||
| await asyncDispatcher(connectToCaseAsyncAction(savedContact.id, undefined)); | ||
| } |
There was a problem hiding this comment.
It's not very clear to me why we disconnect the contact from the case. Are we doing this because:
- that's the expected business rule we've agreed on; or
- just to keep the exact same behaviour that we previously had (when using twilio sync)
There was a problem hiding this comment.
Because there are issues around transferring cases, because the case is owned by the original creator, so there are permissions issues so we are avoiding the problem by disconnecting cases on transfer for now, but we plan to bring transferring cases in once we know what to do in the various permission scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Related Issues
Fixes CHI-2138:
Verification steps