Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Voice Transfers #2390

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Fix Voice Transfers #2390

merged 2 commits into from
Jul 11, 2024

Conversation

murilovmachado
Copy link
Contributor

@murilovmachado murilovmachado commented Jul 10, 2024

Description

This is a temporary fix to the voice transfers issue we're having on SG STG.

The main thing here is:

  • When transferring a call
  • Right before it happens, we check if the task attributes contains conference info
  • If not, we update the task attributes to include it
  • And transfers will work after that

This PR also fixes:

  • Mute feature: it now doesn't look at the task attributes anymore

This PR doesn't fix:

  • It does not fix the root cause
    • That is: why conference is not the task attributes when the call is accepted
  • Right after the transfer is succeeded, the original counselor gets a 500 on the chrome console:
    • POST https://serverless-3066-production.twil.io/conference/updateParticipant 500
    • Probably because callSid is undefined

Other Related Issues

https://tech-matters.atlassian.net/browse/CHI-2847

@murilovmachado murilovmachado changed the base branch from master to v2.15-rc July 10, 2024 20:20
@murilovmachado murilovmachado merged commit c071caf into v2.15-rc Jul 11, 2024
9 checks passed
@murilovmachado murilovmachado deleted the murilo-fix-conference-2 branch July 11, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant