-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHI-2994: Add deployment matrix update to self hosted deploy #2563
Conversation
Add steps to automatically disable Twilio hosted plugins for self hosted deploys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Something I was wondering. Would i make more sense to have this logic in the "main-action" action (which is mostly twilio-hosted logic) or an adjacent action like "self-host action"?
The action seems redundant at this point, since the only place that calls it is the Flex Deploy workflow, so the logic may as well be inline there. I think that action used to be called directly from several workflows, but now those all call Flex Deploy |
Description
Also add steps to automatically disable Twilio hosted plugins for self hosted deploys
Most of the deploy speed benefit has been lost because the flex plugins CLI doesn't seem to be able to disable a plugin without running from the plugins source directory with all the dependencies installed, for some reason - I opened a ticket with Twilio about this because it seems like a but
But we will regain most of that when the support for Twilio hosted plugins is dropped
Checklist
Other Related Issues
None
Verification steps
Tested workflows
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P