Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHI-2994: Add deployment matrix update to self hosted deploy #2563

Merged
merged 11 commits into from
Oct 17, 2024

Conversation

stephenhand
Copy link
Collaborator

@stephenhand stephenhand commented Oct 15, 2024

Description

Also add steps to automatically disable Twilio hosted plugins for self hosted deploys

Most of the deploy speed benefit has been lost because the flex plugins CLI doesn't seem to be able to disable a plugin without running from the plugins source directory with all the dependencies installed, for some reason - I opened a ticket with Twilio about this because it seems like a but

But we will regain most of that when the support for Twilio hosted plugins is dropped

Checklist

  • Corresponding issue has been opened
  • N/A New tests added
  • Feature flags added
  • N/A Strings are localized
  • N/A Tested for chat contacts
  • N/A Tested for call contacts

Other Related Issues

None

Verification steps

Tested workflows

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@stephenhand stephenhand marked this pull request as ready for review October 16, 2024 07:49
Copy link
Collaborator

@mythilytm mythilytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Something I was wondering. Would i make more sense to have this logic in the "main-action" action (which is mostly twilio-hosted logic) or an adjacent action like "self-host action"?

@stephenhand stephenhand merged commit 310bb81 into master Oct 17, 2024
15 checks passed
@stephenhand stephenhand deleted the CHI-2994-fix_rate_limits_deploys branch October 17, 2024 12:36
@stephenhand
Copy link
Collaborator Author

LGTM. Something I was wondering. Would i make more sense to have this logic in the "main-action" action (which is mostly twilio-hosted logic) or an adjacent action like "self-host action"?

The action seems redundant at this point, since the only place that calls it is the Flex Deploy workflow, so the logic may as well be inline there. I think that action used to be called directly from several workflows, but now those all call Flex Deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants