[Bug fix] Make channel capture cleanup function compatible with chann…

…el not captured (#511)

functions/channelCapture/channelCaptureHandlers.private.ts

@@ -160,10 +160,6 @@ const triggerWithUserMessage = async (
     inputText,
   });
 
-  if (lexResult.status === 'failure') {
-    throw lexResult.error;
-  }
-
   const chatbotCallbackWebhook = await channel.webhooks().create({
     type: 'webhook',
     configuration: {
@@ -186,6 +182,11 @@ const triggerWithUserMessage = async (
     chatbotCallbackWebhookSid: chatbotCallbackWebhook.sid,
   });
 
+  // Bubble exception after the channel is updated because capture attributes are needed for the cleanup
+  if (lexResult.status === 'failure') {
+    throw lexResult.error;
+  }
+
   const { lexResponse } = lexResult;
 
   // Send message to trigger the recently created chatbot integration
@@ -506,7 +507,7 @@ const handlePostSurveyComplete = async (
         : !postSurveyConfigJson
         ? `No postSurveyConfigJson found for definitionVersion ${definitionVersion}.`
         : `postSurveyConfigJson for definitionVersion ${definitionVersion} is not a Twilio asset as expected`; // This should removed when if we move definition versions to an external source.
-    console.error(`Error accessing to the post survey form definitions: ${errorMEssage}`);
+    console.info(`Error accessing to the post survey form definitions: ${errorMEssage}`);
   }
 };
 

functions/channelCapture/lexClient.private.ts

@@ -21,8 +21,6 @@ export type AWSCredentials = {
   AWS_REGION: string;
 };
 
-export type BotType = 'pre_survey' | 'post_survey';
-
 export type LexMemory = { [q: string]: string | number };
 
 export const postText = async (
@@ -55,14 +53,17 @@ export const postText = async (
 
     return { status: 'success', lexResponse } as const;
   } catch (error) {
-    return { status: 'failure', error } as { status: 'failure'; error: Error };
+    return {
+      status: 'failure',
+      error: error instanceof Error ? error : new Error(String(error)),
+    } as const;
   }
 };
 
 export const isEndOfDialog = (dialogState: string | undefined) =>
   dialogState === 'Fulfilled' || dialogState === 'Failed';
 
-export const deleteSession = (
+export const deleteSession = async (
   credentials: AWSCredentials,
   {
     botName,
@@ -74,21 +75,30 @@ export const deleteSession = (
     userId: string;
   },
 ) => {
-  AWS.config.update({
-    credentials: {
-      accessKeyId: credentials.ASELO_APP_ACCESS_KEY,
-      secretAccessKey: credentials.ASELO_APP_SECRET_KEY,
-    },
-    region: credentials.AWS_REGION,
-  });
+  try {
+    AWS.config.update({
+      credentials: {
+        accessKeyId: credentials.ASELO_APP_ACCESS_KEY,
+        secretAccessKey: credentials.ASELO_APP_SECRET_KEY,
+      },
+      region: credentials.AWS_REGION,
+    });
+
+    const Lex = new AWS.LexRuntime();
 
-  const Lex = new AWS.LexRuntime();
+    const lexResponse = await Lex.deleteSession({
+      botName,
+      botAlias,
+      userId,
+    }).promise();
 
-  return Lex.deleteSession({
-    botName,
-    botAlias,
-    userId,
-  }).promise();
+    return { status: 'success', lexResponse } as const;
+  } catch (error) {
+    return {
+      status: 'failure',
+      error: error instanceof Error ? error : new Error(String(error)),
+    } as const;
+  }
 };
 
 export type LexClient = {

functions/helpers/addCustomerExternalId.private.ts

@@ -41,7 +41,7 @@ const logAndReturnError = (
   errorInstance: unknown,
 ) => {
   const errorMessage = `Error at addCustomerExternalId: task with sid ${taskSid} does not exists in workspace ${workspaceSid} when trying to ${step} it.`;
-  console.error(errorMessage, errorInstance);
+  console.info(errorMessage, errorInstance);
   return { message: errorMessage };
 };
 

functions/postSurveyComplete.protected.ts

@@ -123,7 +123,7 @@ const getPostSurveyCompleteMessage = async (
 
     if (translation.postSurveyCompleteMessage) return translation.postSurveyCompleteMessage;
   } catch {
-    console.error(
+    console.info(
       `Couldn't retrieve postSurveyCompleteMessage translation for ${taskLanguage}, neither default (en-US).`,
     );
   }
@@ -196,7 +196,7 @@ export const handler: ServerlessFunctionSignature<EnvVars, Event> = async (
               : !postSurveyConfigJson
               ? `No postSurveyConfigJson found for definitionVersion ${definitionVersion}.`
               : `postSurveyConfigJson for definitionVersion ${definitionVersion} is not a Twilio asset as expected`; // This should removed when if we move definition versions to an external source.
-          console.error(`Error accessing to the post survey form definitions: ${errorMEssage}`);
+          console.info(`Error accessing to the post survey form definitions: ${errorMEssage}`);
         }
 
         // As survey tasks will never be assigned to a worker, they'll be kept in pending state. A pending can't transition to completed state, so we cancel them here to raise a task.canceled taskrouter event.

functions/postSurveyInit.ts

@@ -123,7 +123,7 @@ const getTriggerMessage = async (
 
       if (translation.triggerMessage) return translation.triggerMessage;
     } catch {
-      console.error(`Couldn't retrieve triggerMessage translation for ${taskLanguage}`);
+      console.info(`Couldn't retrieve triggerMessage translation for ${taskLanguage}`);
     }
   }
 

tests/helpers/addCustomerExternalId.test.ts

@@ -71,7 +71,7 @@ const baseContext = {
 
 const liveAttributes = { some: 'some', customers: { other: 1 } };
 
-const logSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
+const logSpy = jest.spyOn(console, 'info').mockImplementation(() => {});
 
 beforeAll(() => {
   helpers.setup({});