Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHI-3005: Don't increase chat capacity for conversation transfers #707

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

stephenhand
Copy link
Collaborator

Description

Because conversations uses an alternative approach for transferring conversations i think (testing to confirm) that spare capacity isn't required to accept a transfer.

Trying to adjust for the incoming convo is having an undesirable effect, because the transferred convo already counts to the workers current chat capacity even though it is not accepted yet. This means that when we do increase capacity to 'current tasks plus one' to make room for the transfer, we are actually making room for another random task

This PR removes that pre-adjustment for conversations chat transfers

Checklist

  • Corresponding issue has been opened
  • New tests added
  • N/A Feature flags / configuration added

Other Related Issues

None

Verification steps

See ticket

AFTER YOU MERGE

  1. Cut a release tag using the GitHub workflow. Wait for it to complete and the notification to be posted in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

…he flex interactions invite does not need capacity to be available
@stephenhand stephenhand merged commit 5af29d7 into master Oct 25, 2024
2 checks passed
@stephenhand stephenhand deleted the CHI-3005-just_fix branch October 25, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants