Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHI-2960: Fix call to remove original participant from a conversation during a queue transfer #708

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

stephenhand
Copy link
Collaborator

@stephenhand stephenhand commented Oct 21, 2024

Description

Fix issue where a task sid was being passed to the call to remove original participants from a conversation during a queue transfer. The function requires a task object

Checklist

  • Corresponding issue has been opened
  • New tests added
  • N./A Feature flags / configuration added

Other Related Issues

None

Verification steps

See ticket

AFTER YOU MERGE

  1. Cut a release tag using the GitHub workflow. Wait for it to complete and the notification to be posted in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@stephenhand stephenhand changed the title CHI-2960: Ensure queue target is correctly set on queue transfers CHI-2960: Oct 22, 2024
@stephenhand stephenhand changed the title CHI-2960: CHI-2960: Fix call to remove original participant from a conversation during a queue transfer Oct 22, 2024
@stephenhand stephenhand marked this pull request as ready for review October 22, 2024 14:13
Copy link
Collaborator

@mythilytm mythilytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stephenhand stephenhand merged commit a9b8ed5 into master Oct 24, 2024
4 checks passed
@stephenhand stephenhand deleted the CHI-2960-queue_transfer_issues branch October 24, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants