Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHI-2960: Fix call to remove original participant from a conversation during a queue transfer #708

Merged
merged 5 commits into from
Oct 24, 2024
Merged

CHI-2960: Fix call to remove original participant from a conversation during a queue transfer #708

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
485c1a6
Ensure queue target is correctly set on queue transfers
stephenhand Oct 21, 2024
cab9b88
Revert setting queue for conversations queue transfer
stephenhand Oct 21, 2024
d52cee2
Merge branch 'master' into CHI-2960-queue_transfer_issues
stephenhand Oct 22, 2024
7e0bd06
Improve logging
stephenhand Oct 22, 2024
1086f3f
Improve logging
stephenhand Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions functions/taskrouterListeners/transfersListener.private.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ export const handleEvent = async (context: Context<EnvVars>, event: EventFields)

const client = context.getTwilioClient();

await client.taskrouter.v1.workspaces
const originalTask = await client.taskrouter.v1.workspaces
.get(context.TWILIO_WORKSPACE_SID)
.tasks.get(originalTaskSid)
.update({
Expand All @@ -240,13 +240,14 @@ export const handleEvent = async (context: Context<EnvVars>, event: EventFields)
await transitionAgentParticipants(
context.getTwilioClient(),
context.TWILIO_WORKSPACE_SID,
originalTaskSid,
originalTask,
'closed',
taskAttributes.originalParticipantSid,
);
} catch (err) {
console.error(
`Error closing original participant ${taskAttributes.originalParticipantSid} from interaction channel ${taskAttributes.conversationSid}`,
err,
);
}
}
Expand Down
Loading