Update Support for 'facebook' and 'messenger' #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythilytm
commented
Oct 24, 2024
| instagram: [], | ||
| line: [], | ||
| telegram: [], |
There was a problem hiding this comment.
telegram was missing
GPaoloni
reviewed
Oct 24, 2024
Comment on lines
97
to
+98
| facebook: [(s) => s.replace('messenger:', '')], | ||
| messenger: [(s) => s.replace('messenger:', '')], |
There was a problem hiding this comment.
Would we need a migration to align facebook to messenger, or we plan to have both in the DB?
There was a problem hiding this comment.
Refer slack for rest of conversation
- We will migrate once programmable chat is deprecated in our codebase. For now, we will have both.
mythilytm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P