Merge pull request #25 from techno-dwarf-works/feature/refactoring

Version 0.0.22
techno-dwarf-works · Jul 20, 2024 · 34bf7e5 · 34bf7e5
1 parent ae24762
commit 34bf7e5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/Editor/Drawers/SerializeReferenceField.cs b/Editor/Drawers/SerializeReferenceField.cs
@@ -106,16 +106,17 @@ private void Update()
                 }
                 finally
                 {
+                    if (_bufferLabel != null)
+                    {
+                        _bufferLabel.RemoveFromHierarchy();
+                        _bufferLabel = null;
+                    }
+
                     if (TryCreateBufferLabel(property, out var label))
                     {
                         _bufferLabel = label;
                         Insert(0, _bufferLabel);
                     }
-                    else
-                    {
-                        _bufferLabel?.RemoveFromHierarchy();
-                        _bufferLabel = null;
-                    }
                 }
 
                 using (var e = ReferenceTypeChangeEvent.GetPooled(_referenceType, newType))
@@ -135,7 +136,7 @@ private bool TryCreateBufferLabel(SerializedProperty property, out Label label)
             var query = this.Query<SerializeReferenceField>().Last();
             if (query == this)
             {
-                if (property.managedReferenceFullTypename.IsNullOrEmpty())
+                if (property.managedReferenceFullTypename.IsNullOrEmpty() || !property.hasVisibleChildren)
                 {
                     label = VisualElementUtility.CreateLabel(PropertyField.label);
                     label.AddToClassList(StyleDefinition.CombineSubState(nameof(SerializeReferenceField), "dummy-label"));

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "com.tdw.better.commons",
   "displayName": "Better Commons",
-  "version": "0.0.21",
+  "version": "0.0.22",
   "unity": "2021.3",
   "description": " ",
   "dependencies": {