Merge pull request #46 from techno-dwarf-works/feature/refactoring

Version 0.0.43
techno-dwarf-works · Aug 18, 2024 · a8f162c · a8f162c
2 parents 29d965a + fd29d70
commit a8f162c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/Assets/BetterCommons/Editor/Extensions/SerializedPropertyExtensions.cs b/Assets/BetterCommons/Editor/Extensions/SerializedPropertyExtensions.cs
@@ -108,10 +108,14 @@ public static CachedFieldInfo GetFieldInfoAndStaticTypeFromProperty(this Seriali
             var fieldPath = self.propertyPath;
             if (self.propertyType == SerializedPropertyType.ManagedReference)
             {
-                var objectTypename = self.managedReferenceFullTypename;
-                if (!SerializedPropertyUtility.GetTypeFromManagedReferenceFullTypeName(objectTypename, out classType))
+                if (!self.managedReferenceFullTypename.IsNullOrEmpty())
                 {
-                    return null;
+                    var objectTypename = self.managedReferenceFullTypename;
+
+                    if (!SerializedPropertyUtility.GetTypeFromManagedReferenceFullTypeName(objectTypename, out classType))
+                    {
+                        return null;
+                    }
                 }
 
                 fieldPath = self.propertyPath;
@@ -231,7 +235,7 @@ public static bool IsDisposed(this SerializedProperty self)
             {
                 return false;
             }
-            
+
             try
             {
                 if (PropertyPrtInfo != null && ObjectPrtInfo != null)

diff --git a/Assets/BetterCommons/Editor/Utility/SerializedPropertyUtility.cs b/Assets/BetterCommons/Editor/Utility/SerializedPropertyUtility.cs
@@ -60,8 +60,11 @@ public static bool GetTypeFromManagedReferenceFullTypeName(string managedReferen
                 var classNamePart = parts[1];
                 managedReferenceInstanceType = Type.GetType($"{classNamePart}, {assemblyPart}");
             }
+            else
+            {
+                managedReferenceInstanceType = null;
+            }
 
-            managedReferenceInstanceType = null;
             return managedReferenceInstanceType != null;
         }
 

diff --git a/Assets/BetterCommons/package.json b/Assets/BetterCommons/package.json
@@ -1,7 +1,7 @@
 {
   "name": "com.tdw.better.commons",
   "displayName": "Better Commons",
-  "version": "0.0.42",
+  "version": "0.0.43",
   "unity": "2021.3",
   "description": " ",
   "dependencies": {