Portability fixes; debian arduino makefile #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for these contributions. I'm puzzled why the C forward declarations are needed on Debian but not on other Arduino IDE platforms. |
|
@technoblogy apparently, some of these are also required on OpenBSD, (See: https://github.com/technoblogy/ulisp/pull/22/files). |
|
Thank you. I'll add a link to this thread from the documentation for Debian and OpenBSD users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get ulisp 1.8 to compile, I had to make a number of minor C portability fixes, such as additional forward declarations and a missing include.
Let me know if you want me to refashion this branch to remove the Makefile snippet, I realize that one is a bit iffy to push upstream. But seems harmless for folks using the Arduino IDE (just ignored).