Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements #96

Merged
merged 5 commits into from
Sep 8, 2024
Merged

Enhancements #96

merged 5 commits into from
Sep 8, 2024

Conversation

techthoughts2
Copy link
Owner

Pull Request

Description

  • Catesta template module changes
    • Improved Windows detection checks for Pester module installation
  • Catesta primary module changes
    • Improved Windows detection checks for Pester module installation
    • Fixed FileChecks.Tests.ps1 where certain tests were not being run.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

SamErde and others added 5 commits August 21, 2024 08:47
…ap.ps1

Enhanced Windows check while installing Pester to support Windows PowerShell 5.1. It currently checks for $IsWindows, which was only introduced in PowerShell 6.

I updated it to `-and ($IsWindows -or $PSVersionTable.PSVersion -ge [version]'5.1')` but if minimal code is desired, it could be simplified to `-and $PSVersionTable.PSVersion -ge [version]'5.1')`.
Enhancement - Windows PowerShell 5.1 compatibility
@techthoughts2 techthoughts2 added bug Something isn't working enhancement New feature or request labels Sep 8, 2024
@techthoughts2 techthoughts2 self-assigned this Sep 8, 2024
@techthoughts2 techthoughts2 merged commit e3a8bee into main Sep 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants