Add phpstan check and fix level 0 issues.

tecnickcom · Oct 10, 2023 · cc6dbfc · cc6dbfc
1 parent 0bd1fdb
commit cc6dbfc
Show file tree

Hide file tree

Showing 7 changed files with 39 additions and 19 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -60,3 +60,22 @@ jobs:
               with:
                 flags: php-${{ matrix.php-version }}-${{ matrix.os }}
                 name: php-${{ matrix.php-version }}-${{ matrix.os }}
+
+    static-analysis:
+        name: Static Analysis
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@v4
+            - name: Use php 8.2
+              uses: shivammathur/setup-php@v2
+              with:
+                  php-version: 8.2
+            - name: Cache module
+              uses: actions/cache@v3
+              with:
+                  path: ~/.composer/cache/
+                  key: composer-cache
+            - name: Install phpstan
+              run: composer require --dev phpstan/phpstan
+            - name: Analyse files
+              run: ./vendor/bin/phpstan analyse src test
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-2.4.23
+2.4.25
diff --git a/resources/debian/control b/resources/debian/control
@@ -10,6 +10,6 @@ Vcs-Git: https://github.com/~#VENDOR#~/~#PROJECT#~.git
 Package: ~#PKGNAME#~
 Provides: php-~#PROJECT#~
 Architecture: all
-Depends: php (>= 5.4.0), php-tecnickcom-tc-lib-pdf-filter (<< 2.0.0), php-tecnickcom-tc-lib-pdf-filter (>= 1.4.27), ${misc:Depends}
+Depends: php (>= 5.4.0), php-tecnickcom-tc-lib-pdf-filter (<< 2.0.0), php-tecnickcom-tc-lib-pdf-filter (>= 1.4.29), ${misc:Depends}
 Description: PHP PDF Parser Library
  PHP library to parse PDF documents.
diff --git a/resources/rpm/rpm.spec b/resources/rpm/rpm.spec
@@ -18,7 +18,7 @@ BuildArch: noarch
 
 Requires:  php(language) >= 5.4.0
 Requires:  php-composer(%{c_vendor}/tc-lib-pdf-filter) < 2.0.0
-Requires:  php-composer(%{c_vendor}/tc-lib-pdf-filter) >= 1.4.27
+Requires:  php-composer(%{c_vendor}/tc-lib-pdf-filter) >= 1.4.29
 Requires:  php-pcre
 
 Provides:  php-composer(%{c_vendor}/%{gh_project}) = %{version}

diff --git a/src/Parser.php b/src/Parser.php
@@ -33,20 +33,6 @@
  */
 class Parser extends \Com\Tecnick\Pdf\Parser\Process\Xref
 {
-    /**
-     * Raw content of the PDF document.
-     *
-     * @var string
-     */
-    protected $pdfdata = '';
-
-    /**
-     * Array of PDF objects.
-     *
-     * @var array
-     */
-    protected $objects = array();
-
     /**
      * Array of configuration parameters.
      *
@@ -228,8 +214,6 @@ protected function decodeStream($sdic, $stream)
      * @param int    $slength Stream length
      * @param array  $sdic    Stream's dictionary array.
      * @param int    $key     Index
-     *
-     * @return array Array of filters
      */
     protected function getDeclaredStreamLength(&$stream, &$slength, $sdic, $key)
     {

diff --git a/src/Process/RawObject.php b/src/Process/RawObject.php
@@ -33,6 +33,20 @@
  */
 abstract class RawObject
 {
+    /**
+     * Raw content of the PDF document.
+     *
+     * @var string
+     */
+    protected $pdfdata = '';
+
+    /**
+     * Array of PDF objects.
+     *
+     * @var array
+     */
+    protected $objects = array();
+
     /**
      * Get object type, raw value and offset to next object
      *

diff --git a/src/Process/Xref.php b/src/Process/Xref.php
@@ -47,6 +47,9 @@ abstract class Xref extends \Com\Tecnick\Pdf\Parser\Process\XrefStream
      */
     protected $mrkoff = array();
 
+
+    abstract protected function getIndirectObject($obj_ref, $offset = 0, $decoding = true);
+
     /**
      * Get Cross-Reference (xref) table and trailer data from PDF document data.
      *