Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#110 API cleanup, ready for 1.1.0-RC0 #118

Merged
merged 2 commits into from
Nov 5, 2023
Merged

#110 API cleanup, ready for 1.1.0-RC0 #118

merged 2 commits into from
Nov 5, 2023

Conversation

tribbloid
Copy link
Collaborator

voila

@tribbloid
fix a compilation warning
720020a
@tribbloid
large scale refactoring of PluginSettings to minimise boilerplate
7440640 
Aggregate reduction & position into TypeDetail setting

position format has been simplified

scalafix defined & applied
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

Test Report (2.13.8)

101 tests  +2   101 ✔️ +2   10s ⏱️ -4s
  16 suites ±0       0 💤 ±0 
  16 files   ±0       0 ❌ ±0 

Results for commit 7440640. ± Comparison against base commit 7fe1ec1.

This pull request removes 8 and adds 10 tests. Note that renamed tests count towards both. 
splain.plugin.VTypeDefPositionSpec ‑ #44 diff
splain.plugin.VTypeDefPositionSpec ‑ #44 diff - Splain(-P:splain:Vtype-def-position)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:1)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:2)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:3)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:4)
splain.plugin.VTypeReductionSpec ‑ #101 foundReqVsImplicit
splain.plugin.VTypeReductionSpec ‑ #101 foundReqVsImplicit - Splain(-P:splain:Vtype-reduction)

splain.plugin.VTypeDetailPositionSpec ‑ #44 diff
splain.plugin.VTypeDetailPositionSpec ‑ #44 diff - Splain(-P:splain:Vtype-detail:position)
splain.plugin.VTypeDetailReductionSpec ‑ #101 foundReqVsImplicit
splain.plugin.VTypeDetailReductionSpec ‑ #101 foundReqVsImplicit - Splain(-P:splain:Vtype-detail:reduction)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:1)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:2)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:3)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:4)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:5)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:6)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

Test Report (2.13.7)

101 tests  +2   101 ✔️ +2   16s ⏱️ -4s
  16 suites ±0       0 💤 ±0 
  16 files   ±0       0 ❌ ±0 

Results for commit 7440640. ± Comparison against base commit 7fe1ec1.

This pull request removes 8 and adds 10 tests. Note that renamed tests count towards both. 
splain.plugin.VTypeDefPositionSpec ‑ #44 diff
splain.plugin.VTypeDefPositionSpec ‑ #44 diff - Splain(-P:splain:Vtype-def-position)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:1)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:2)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:3)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:4)
splain.plugin.VTypeReductionSpec ‑ #101 foundReqVsImplicit
splain.plugin.VTypeReductionSpec ‑ #101 foundReqVsImplicit - Splain(-P:splain:Vtype-reduction)

splain.plugin.VTypeDetailPositionSpec ‑ #44 diff
splain.plugin.VTypeDetailPositionSpec ‑ #44 diff - Splain(-P:splain:Vtype-detail:position)
splain.plugin.VTypeDetailReductionSpec ‑ #101 foundReqVsImplicit
splain.plugin.VTypeDetailReductionSpec ‑ #101 foundReqVsImplicit - Splain(-P:splain:Vtype-detail:reduction)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:1)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:2)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:3)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:4)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:5)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:6)

@tribbloid tribbloid changed the title #110 API cleanup, ready for 1.1.0-RC1 #110 API cleanup, ready for 1.1.0-RC0 Nov 4, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

Test Report (2.13.9)

101 tests  +2   101 ✔️ +2   10s ⏱️ -3s
  16 suites ±0       0 💤 ±0 
  16 files   ±0       0 ❌ ±0 

Results for commit 7440640. ± Comparison against base commit 7fe1ec1.

This pull request removes 8 and adds 10 tests. Note that renamed tests count towards both. 
splain.plugin.VTypeDefPositionSpec ‑ #44 diff
splain.plugin.VTypeDefPositionSpec ‑ #44 diff - Splain(-P:splain:Vtype-def-position)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:1)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:2)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:3)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:4)
splain.plugin.VTypeReductionSpec ‑ #101 foundReqVsImplicit
splain.plugin.VTypeReductionSpec ‑ #101 foundReqVsImplicit - Splain(-P:splain:Vtype-reduction)

splain.plugin.VTypeDetailPositionSpec ‑ #44 diff
splain.plugin.VTypeDetailPositionSpec ‑ #44 diff - Splain(-P:splain:Vtype-detail:position)
splain.plugin.VTypeDetailReductionSpec ‑ #101 foundReqVsImplicit
splain.plugin.VTypeDetailReductionSpec ‑ #101 foundReqVsImplicit - Splain(-P:splain:Vtype-detail:reduction)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:1)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:2)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:3)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:4)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:5)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:6)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

Test Report (2.13.10)

101 tests  +2   101 ✔️ +2   10s ⏱️ -3s
  16 suites ±0       0 💤 ±0 
  16 files   ±0       0 ❌ ±0 

Results for commit 7440640. ± Comparison against base commit 7fe1ec1.

This pull request removes 8 and adds 10 tests. Note that renamed tests count towards both. 
splain.plugin.VTypeDefPositionSpec ‑ #44 diff
splain.plugin.VTypeDefPositionSpec ‑ #44 diff - Splain(-P:splain:Vtype-def-position)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:1)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:2)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:3)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:4)
splain.plugin.VTypeReductionSpec ‑ #101 foundReqVsImplicit
splain.plugin.VTypeReductionSpec ‑ #101 foundReqVsImplicit - Splain(-P:splain:Vtype-reduction)

splain.plugin.VTypeDetailPositionSpec ‑ #44 diff
splain.plugin.VTypeDetailPositionSpec ‑ #44 diff - Splain(-P:splain:Vtype-detail:position)
splain.plugin.VTypeDetailReductionSpec ‑ #101 foundReqVsImplicit
splain.plugin.VTypeDetailReductionSpec ‑ #101 foundReqVsImplicit - Splain(-P:splain:Vtype-detail:reduction)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:1)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:2)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:3)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:4)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:5)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:6)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

Test Report (2.13.11)

101 tests  +2   101 ✔️ +2   10s ⏱️ -4s
  16 suites ±0       0 💤 ±0 
  16 files   ±0       0 ❌ ±0 

Results for commit 7440640. ± Comparison against base commit 7fe1ec1.

This pull request removes 8 and adds 10 tests. Note that renamed tests count towards both. 
splain.plugin.VTypeDefPositionSpec ‑ #44 diff
splain.plugin.VTypeDefPositionSpec ‑ #44 diff - Splain(-P:splain:Vtype-def-position)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:1)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:2)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:3)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:4)
splain.plugin.VTypeReductionSpec ‑ #101 foundReqVsImplicit
splain.plugin.VTypeReductionSpec ‑ #101 foundReqVsImplicit - Splain(-P:splain:Vtype-reduction)

splain.plugin.VTypeDetailPositionSpec ‑ #44 diff
splain.plugin.VTypeDetailPositionSpec ‑ #44 diff - Splain(-P:splain:Vtype-detail:position)
splain.plugin.VTypeDetailReductionSpec ‑ #101 foundReqVsImplicit
splain.plugin.VTypeDetailReductionSpec ‑ #101 foundReqVsImplicit - Splain(-P:splain:Vtype-detail:reduction)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:1)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:2)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:3)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:4)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:5)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:6)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

Test Report (2.13.12)

101 tests  +2   101 ✔️ +2   16s ⏱️ -1s
  16 suites ±0       0 💤 ±0 
  16 files   ±0       0 ❌ ±0 

Results for commit 7440640. ± Comparison against base commit 7fe1ec1.

This pull request removes 8 and adds 10 tests. Note that renamed tests count towards both. 
splain.plugin.VTypeDefPositionSpec ‑ #44 diff
splain.plugin.VTypeDefPositionSpec ‑ #44 diff - Splain(-P:splain:Vtype-def-position)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:1)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:2)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:3)
splain.plugin.VTypeDetailsSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:4)
splain.plugin.VTypeReductionSpec ‑ #101 foundReqVsImplicit
splain.plugin.VTypeReductionSpec ‑ #101 foundReqVsImplicit - Splain(-P:splain:Vtype-reduction)

splain.plugin.VTypeDetailPositionSpec ‑ #44 diff
splain.plugin.VTypeDetailPositionSpec ‑ #44 diff - Splain(-P:splain:Vtype-detail:position)
splain.plugin.VTypeDetailReductionSpec ‑ #101 foundReqVsImplicit
splain.plugin.VTypeDetailReductionSpec ‑ #101 foundReqVsImplicit - Splain(-P:splain:Vtype-detail:reduction)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:1)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:2)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:3)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:4)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:5)
splain.plugin.VTypeDetailSpec ‑ #113 wrongContexts - Splain(-P:splain:Vtype-detail:6)

@tribbloid tribbloid requested a review from tek November 4, 2023 22:34
@tribbloid tribbloid merged commit 17a9f8d into master Nov 5, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tek tek tek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tribbloid @tek