Skip to content

Commit

Permalink
misc: promote keep-pod-on-cancel to default
Browse files Browse the repository at this point in the history
Signed-off-by: chengjoey <zchengjoey@gmail.com>
  • Loading branch information
chengjoey committed Oct 23, 2024
1 parent a81850c commit 142577e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions config/config-feature-flags.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,9 @@ data:
# Not all Kubernetes implementations support this option.
set-security-context: "false"
# Setting this flag to "true" will keep pod on cancellation
# allowing examination of the logs on the pods from cancelled taskruns
keep-pod-on-cancel: "false"
# Allowing examination of the logs on the pods from cancelled taskruns
# To disable populating this field, set this flag to `"false"`
keep-pod-on-cancel: "true"
# Setting this flag to "true" will enable the CEL evaluation in WhenExpression
enable-cel-in-whenexpression: "false"
# Setting this flag to "true" will enable the use of StepActions in Steps
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/config/feature_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ var (
DefaultEnableKeepPodOnCancel = PerFeatureFlag{
Name: KeepPodOnCancel,
Stability: AlphaAPIFields,
Enabled: DefaultAlphaFeatureEnabled,
Enabled: DefaultBetaFeatureEnabled,
}

// DefaultEnableCELInWhenExpression is the default PerFeatureFlag value for EnableCELInWhenExpression
Expand Down

0 comments on commit 142577e

Please sign in to comment.