From 142577e1de00664fc97a9ff410b82bc1d82b66b8 Mon Sep 17 00:00:00 2001 From: joey Date: Wed, 23 Oct 2024 13:25:45 +0800 Subject: [PATCH] misc: promote `keep-pod-on-cancel` to default Signed-off-by: chengjoey --- config/config-feature-flags.yaml | 5 +++-- pkg/apis/config/feature_flags.go | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/config/config-feature-flags.yaml b/config/config-feature-flags.yaml index 398f37d1880..3b1a582e83c 100644 --- a/config/config-feature-flags.yaml +++ b/config/config-feature-flags.yaml @@ -118,8 +118,9 @@ data: # Not all Kubernetes implementations support this option. set-security-context: "false" # Setting this flag to "true" will keep pod on cancellation - # allowing examination of the logs on the pods from cancelled taskruns - keep-pod-on-cancel: "false" + # Allowing examination of the logs on the pods from cancelled taskruns + # To disable populating this field, set this flag to `"false"` + keep-pod-on-cancel: "true" # Setting this flag to "true" will enable the CEL evaluation in WhenExpression enable-cel-in-whenexpression: "false" # Setting this flag to "true" will enable the use of StepActions in Steps diff --git a/pkg/apis/config/feature_flags.go b/pkg/apis/config/feature_flags.go index d0db62052cf..6e5b6a8c9a5 100644 --- a/pkg/apis/config/feature_flags.go +++ b/pkg/apis/config/feature_flags.go @@ -142,7 +142,7 @@ var ( DefaultEnableKeepPodOnCancel = PerFeatureFlag{ Name: KeepPodOnCancel, Stability: AlphaAPIFields, - Enabled: DefaultAlphaFeatureEnabled, + Enabled: DefaultBetaFeatureEnabled, } // DefaultEnableCELInWhenExpression is the default PerFeatureFlag value for EnableCELInWhenExpression