Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test PR do not review #6916

Closed
wants to merge 1 commit into from
Closed

Test PR do not review #6916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions test/pipelinerun_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ func TestPipelineRun(t *testing.T) {
name: "service account propagation and pipeline param",
testSetup: func(ctx context.Context, t *testing.T, c *clients, namespace string, index int) *v1.Pipeline {
t.Helper()
t.Skip("build-crd-testing project got removed, the secret-sauce doesn't exist anymore, skipping")
if _, err := c.KubeClient.CoreV1().Secrets(namespace).Create(ctx, getPipelineRunSecret(index, namespace), metav1.CreateOptions{}); err != nil {
t.Fatalf("Failed to create secret `%s`: %s", getName(secretName, index), err)
}
Expand Down Expand Up @@ -250,7 +249,6 @@ spec:
name: "pipelinerun succeeds with LimitRange minimum in namespace",
testSetup: func(ctx context.Context, t *testing.T, c *clients, namespace string, index int) *v1.Pipeline {
t.Helper()
t.Skip("build-crd-testing project got removed, the secret-sauce doesn't exist anymore, skipping")
if _, err := c.KubeClient.CoreV1().LimitRanges(namespace).Create(ctx, getLimitRange("prlimitrange", namespace, "100m", "99Mi", "100m"), metav1.CreateOptions{}); err != nil {
t.Fatalf("Failed to create LimitRange `%s`: %s", "prlimitrange", err)
}
Expand Down Expand Up @@ -406,15 +404,15 @@ spec:
params:
- name: the.path
type: string
- name: dest
- name: the.dest
type: string
tasks:
- name: %s
params:
- name: the.path
value: $(params["the.path"])
- name: dest
value: $(params.dest)
- name: the.dest
value: $(params["the.dest"])
taskRef:
name: %s
`, helpers.ObjectNameForTest(t), namespace, task1Name, taskName))
Expand Down Expand Up @@ -763,7 +761,7 @@ spec:
params:
- name: the.path
value: docker://gcr.io/build-crd-testing/secret-sauce
- name: dest
- name: the.dest
value: dir:///tmp/
pipelineRef:
name: %s
Expand Down