Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an issue with InvalidMatrixParameterTypes along with updating the matrix example with additional validations #7064

Merged
merged 1 commit into from
Sep 5, 2023

Commits on Sep 1, 2023

  1. updating example of a matrix feature

    Fixing a bug with InvalidMatrixParameterType when a parameter is not
    part of a matrix but defined as a task parameter of type string,
    pipelineRun results in a failure.
    
    Adding two new validation:
    
    * onError with matrix: when a task fan out for a given number of instances,
    pipeline controller must apply the onError to each running instance.
    
    * retry with matrix: when a task has specified retry, that specification
    must apply to all the instances of fanned out task.
    
    Being consistent with the rest of the reasons, dropping "Reason" from
    "ReasonInvalidMatrixParameterTypes".
    
    Updated the error reported in "ValidateParameterTypesInMatrix" to include
    name of the pipelineTask.
    
    Co-authored-by: EmmaMunley <emmamunley@google.com>
    
    Signed-off-by: Priti Desai <pdesai@us.ibm.com>
    pritidesai committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    b4f27e0 View commit details
    Browse the repository at this point in the history