Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover Conversion Functions from Pipeline Resources for backwards compatibility #7109

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Recover Conversion Functions from Pipeline Resources for backwards compatibility #7109

merged 1 commit into from
Sep 25, 2023

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Sep 13, 2023 •
edited
Loading

Changes

When we reverted removal of PipelineResources related fields,
we did not recover the conversion functions. As a result, when migrating
Tekton Chains to watch v1 objects, we run into Issue #7105.

This PR recovers the conversion functions so that we can continue to convert PipelineResources related fields. It addresses issue #7105.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Recover Conversion Functions from Pipeline Resources for backwards compatibility

/kind bug

@chitrangpatel
Recover Conversion Functions from Pipeline Resources
88d63ea 
When we reverted removal of `PipelineResources` [related fields](tektoncd#6436),
we did not recover the conversion functions. As a result, when migrating
Tekton Chains to watch `v1` objects, we run into Issue
tektoncd#7105.

This PR recovers the conversion functions so that we can continue to
convert PipelineResources related fields.
@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 13, 2023
@chitrangpatel
Copy link
Contributor Author

/assign @wlynch

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 96.5% 95.3% -1.2
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 96.8% 95.7% -1.1
pkg/apis/pipeline/v1beta1/task_conversion.go 93.2% 91.9% -1.3
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 94.1% 93.1% -0.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 96.5% 95.3% -1.2
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 96.8% 95.7% -1.1
pkg/apis/pipeline/v1beta1/task_conversion.go 93.2% 91.9% -1.3
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 94.1% 93.1% -0.9

Yongxuanzhang
Yongxuanzhang reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@pritidesai pritidesai added this to the Pipelines v0.52 milestone Sep 19, 2023
@wlynch
Copy link
Member

wlynch commented Sep 25, 2023

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
@tekton-robot tekton-robot merged commit 0e1b1a3 into tektoncd:main Sep 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@wlynch wlynch

@Yongxuanzhang Yongxuanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.53 LTS
Development

Successfully merging this pull request may close these issues.
6 participants
@chitrangpatel @tekton-robot @wlynch @Yongxuanzhang @pritidesai @jerop