Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run finally pipeline even if task is failed at the validation #8314

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Oct 10, 2024

  1. Run finally pipeline even if task is failed at the validation

    Presently if one of the task in pipeline is consuming result from the previous task
    but the previous failed to produce the result then pipeline fails without running
    the finally tasks. These changes handles tasks which got failed in the validation
    step.
    
    Signed-off-by: divyansh42 <diagrawa@redhat.com>
    divyansh42 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ceb2f6c View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Resolve review comments 1

    Signed-off-by: divyansh42 <diagrawa@redhat.com>
    divyansh42 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    332cb87 View commit details
    Browse the repository at this point in the history
  2. Exit reconcilation and markfailed if finally is not present

    Signed-off-by divyansh42 <diagrawa@redhat.com>
    divyansh42 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c6bf2f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Remove permanent error and improve skip logic

    Signed-off-by: divyansh42 <diagrawa@redhat.com>
    divyansh42 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f15eee6 View commit details
    Browse the repository at this point in the history